From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v5 01/10] pdm-api-types: resources: add helper methods for fields
Date: Wed, 3 Sep 2025 15:09:17 +0200 [thread overview]
Message-ID: <20250903132351.841830-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250903132351.841830-1-d.csapak@proxmox.com>
namely 'resource_type' and 'status'. All resources have those fields
in one way or another, so adding a helper that one does not have to
use `match` on every call site makes code there shorter.
Adds a ResourceType enum as a helper, since that can come in handy when
comparing/showing/etc. the types
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v4:
* added ResourceType enum, that converts from str and to str
lib/pdm-api-types/src/resource.rs | 72 +++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)
diff --git a/lib/pdm-api-types/src/resource.rs b/lib/pdm-api-types/src/resource.rs
index 6227855..fd2d49b 100644
--- a/lib/pdm-api-types/src/resource.rs
+++ b/lib/pdm-api-types/src/resource.rs
@@ -1,3 +1,4 @@
+use anyhow::{bail, Error};
use serde::{Deserialize, Serialize};
use proxmox_schema::api;
@@ -62,6 +63,77 @@ impl Resource {
Resource::PbsDatastore(r) => r.name.as_str(),
}
}
+
+ pub fn resource_type(&self) -> ResourceType {
+ match self {
+ Resource::PveStorage(_) => ResourceType::PveStorage,
+ Resource::PveQemu(_) => ResourceType::PveQemu,
+ Resource::PveLxc(_) => ResourceType::PveLxc,
+ Resource::PveNode(_) | Resource::PbsNode(_) => ResourceType::Node,
+ Resource::PbsDatastore(_) => ResourceType::PbsDatastore,
+ }
+ }
+
+ pub fn status(&self) -> &str {
+ match self {
+ Resource::PveStorage(r) => r.status.as_str(),
+ Resource::PveQemu(r) => r.status.as_str(),
+ Resource::PveLxc(r) => r.status.as_str(),
+ Resource::PveNode(r) => r.status.as_str(),
+ Resource::PbsNode(r) => {
+ if r.uptime > 0 {
+ "online"
+ } else {
+ "offline"
+ }
+ }
+ Resource::PbsDatastore(_) => "online",
+ }
+ }
+}
+
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+pub enum ResourceType {
+ PveStorage,
+ PveQemu,
+ PveLxc,
+ PbsDatastore,
+ Node,
+}
+
+impl ResourceType {
+ /// Returns a string representation of the type
+ pub fn as_str(&self) -> &'static str {
+ match self {
+ ResourceType::PveStorage => "storage",
+ ResourceType::PveQemu => "qemu",
+ ResourceType::PveLxc => "lxc",
+ ResourceType::PbsDatastore => "datastore",
+ ResourceType::Node => "node",
+ }
+ }
+}
+
+impl std::fmt::Display for ResourceType {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ write!(f, "{}", self.as_str())
+ }
+}
+
+impl std::str::FromStr for ResourceType {
+ type Err = Error;
+
+ fn from_str(s: &str) -> Result<Self, Self::Err> {
+ let resource_type = match s {
+ "storage" => ResourceType::PveStorage,
+ "qemu" => ResourceType::PveQemu,
+ "lxc" => ResourceType::PveLxc,
+ "datastore" => ResourceType::PbsDatastore,
+ "node" => ResourceType::Node,
+ _ => bail!("invalid resource type"),
+ };
+ Ok(resource_type)
+ }
}
#[api(
--
2.47.2
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-09-03 13:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 13:09 [pdm-devel] [PATCH datacenter-manager v5 00/10] implement more complex search syntax Dominik Csapak
2025-09-03 13:09 ` Dominik Csapak [this message]
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 02/10] lib: add pdm-search crate Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 03/10] server: api: resources: add more complex filter syntax Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 04/10] ui: add possibility to insert into search box Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 05/10] ui: dashboard: remotes panel: open search on click Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 06/10] ui: dashboard: guest panel: search for guest states when clicking on them Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 07/10] ui: dashboard: search for nodes when clicking on the nodes panel Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 08/10] ui: search box: add clear trigger Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 09/10] ui: dashboard: guest panel: use `List` instead of `DataTable` Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 10/10] ui: dashboard: guest panel: add search icon for better discoverability Dominik Csapak
2025-09-04 17:21 ` [pdm-devel] applied-series: [PATCH datacenter-manager v5 00/10] implement more complex search syntax Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903132351.841830-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox