public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v5 00/10] implement more complex search syntax
Date: Wed,  3 Sep 2025 15:09:16 +0200	[thread overview]
Message-ID: <20250903132351.841830-1-d.csapak@proxmox.com> (raw)

this introduces a more complex search syntax for the resources api call
and uses that with the dashboard to show relevant resources, e.g.
when clicking on the remotes panel when there are failed remotes, it
adds a search to the box that filters for offline remotes. Same
for clicking on the running vm count, etc.

The syntax is a first draft of mine, we can still tweak and change it
as we see fit, but it's a start.

a 'normal' search term gets filtered to id/name so that does not change
as before, but you can now specify 'categories' with `category:value`
e.g. it's now possible to search for `type:remote` or `status:offline`

it also adds the possibility to mark terms as required like this:

+someterm

required terms have to exist in the resulting resource, while optional
ones are OR'd (so at least one optional match must exist)

Not implemented yet are (but can be done afterwards):
* GUI for filtering
* Include subscription status
* negation of terms (this get's complicated fast ;) )

changes from v4:
* integrated suggestions from wolfgang and shannon (see specific patches
  for details)
* made SearchTerm always parse from &str, so an empty string as well
  as things like ":foo", "foo:" and "+" are valid searchterms now
  (even if they can't find anything at the moment)
* added more useful searches to the node panel
  (added a status when e.g. nodes are offline or unknown)

changes from v3:
* use 'starts_with' for type/status filtering
* add missing doc comments
* add more tests
* refactor guest panel in dashboard to use `List`
* add icon in guest panel for discoverability

changes from v2:
* incorporated stefans feedback for FromIterator, Default, etc.
* added tests for the 'matches' function
* add required search term for the guest 'All' text

changes from v1:
* added commit to improve text width
* added commit to add clear trigger to search box
* rebased on master

Dominik Csapak (10):
  pdm-api-types: resources: add helper methods for fields
  lib: add pdm-search crate
  server: api: resources: add more complex filter syntax
  ui: add possibility to insert into search box
  ui: dashboard: remotes panel: open search on click
  ui: dashboard: guest panel: search for guest states when clicking on
    them
  ui: dashboard: search for nodes when clicking on the nodes panel
  ui: search box: add clear trigger
  ui: dashboard: guest panel: use `List` instead of `DataTable`
  ui: dashboard: guest panel: add search icon for better discoverability

 Cargo.toml                        |   2 +
 lib/pdm-api-types/src/resource.rs |  72 ++++++++
 lib/pdm-search/Cargo.toml         |   9 +
 lib/pdm-search/src/lib.rs         | 267 ++++++++++++++++++++++++++++++
 server/Cargo.toml                 |   1 +
 server/src/api/resources.rs       | 229 +++++++++++++++++++++++--
 ui/Cargo.toml                     |   1 +
 ui/src/dashboard/guest_panel.rs   | 210 +++++++++++++----------
 ui/src/dashboard/mod.rs           |  63 +++++--
 ui/src/dashboard/remote_panel.rs  |  30 +++-
 ui/src/lib.rs                     |   3 +
 ui/src/main.rs                    |  17 +-
 ui/src/pve/mod.rs                 |  21 ++-
 ui/src/search_provider.rs         |  35 ++++
 ui/src/widget/search_box.rs       |  40 ++++-
 15 files changed, 877 insertions(+), 123 deletions(-)
 create mode 100644 lib/pdm-search/Cargo.toml
 create mode 100644 lib/pdm-search/src/lib.rs
 create mode 100644 ui/src/search_provider.rs

-- 
2.47.2



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


             reply	other threads:[~2025-09-03 13:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 13:09 Dominik Csapak [this message]
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 01/10] pdm-api-types: resources: add helper methods for fields Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 02/10] lib: add pdm-search crate Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 03/10] server: api: resources: add more complex filter syntax Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 04/10] ui: add possibility to insert into search box Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 05/10] ui: dashboard: remotes panel: open search on click Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 06/10] ui: dashboard: guest panel: search for guest states when clicking on them Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 07/10] ui: dashboard: search for nodes when clicking on the nodes panel Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 08/10] ui: search box: add clear trigger Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 09/10] ui: dashboard: guest panel: use `List` instead of `DataTable` Dominik Csapak
2025-09-03 13:09 ` [pdm-devel] [PATCH datacenter-manager v5 10/10] ui: dashboard: guest panel: add search icon for better discoverability Dominik Csapak
2025-09-04 17:21 ` [pdm-devel] applied-series: [PATCH datacenter-manager v5 00/10] implement more complex search syntax Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250903132351.841830-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal