From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-api-types 1/3] Schema2Rust: fix handling of non-optional params
Date: Tue, 2 Sep 2025 17:14:19 +0200 [thread overview]
Message-ID: <20250902151427.425017-3-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250902151427.425017-1-l.wagner@proxmox.com>
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
pve-api-types/generator-lib/Schema2Rust.pm | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/pve-api-types/generator-lib/Schema2Rust.pm b/pve-api-types/generator-lib/Schema2Rust.pm
index 77cb373..436ba76 100644
--- a/pve-api-types/generator-lib/Schema2Rust.pm
+++ b/pve-api-types/generator-lib/Schema2Rust.pm
@@ -497,8 +497,10 @@ my sub print_method_without_body : prototype($$$$$) {
print {$out} " .maybe_bool_arg(\"$name\", p_$rust_name)\n";
} elsif ($arg->{is_string_list}) {
print {$out} " .maybe_list_arg(\"$name\", p_$rust_name)\n";
- } else {
+ } elsif ($arg->{optional}) {
print {$out} " .maybe_arg(\"$name\", &p_$rust_name)\n";
+ } else {
+ print {$out} " .arg(\"$name\", &p_$rust_name)\n";
}
}
print {$out} " .build();\n";
@@ -517,12 +519,15 @@ my sub print_method_without_body : prototype($$$$$) {
for my $arg (@$input) {
my $name = $arg->{name};
my $rust_name = $arg->{rust_name};
+
if ($arg->{type} eq 'Option<bool>') {
print {$out} " .maybe_bool_arg(\"$name\", $rust_name)\n";
} elsif ($arg->{is_string_list}) {
print {$out} " .maybe_list_arg(\"$name\", &$rust_name)\n";
- } else {
+ } elsif ($arg->{optional}) {
print {$out} " .maybe_arg(\"$name\", &$rust_name)\n";
+ } else {
+ print {$out} " .arg(\"$name\", &$rust_name)\n";
}
}
print {$out} " .build();\n";
--
2.47.2
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-09-02 15:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 15:14 [pdm-devel] [PATCH manager/proxmox{-api-types, -yew-comp, -datacenter-manager} 00/10] PVE node update view Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH manager 1/1] api: apt: add JSON schema for 'list_updates' endpoint Lukas Wagner
2025-09-03 8:25 ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-02 15:14 ` Lukas Wagner [this message]
2025-09-03 8:57 ` [pdm-devel] applied: [PATCH proxmox-api-types 1/3] Schema2Rust: fix handling of non-optional params Wolfgang Bumiller
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-api-types 2/3] generate: add bindings for various APT functions Lukas Wagner
2025-09-03 8:58 ` [pdm-devel] applied: " Wolfgang Bumiller
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-api-types 3/3] refresh bindings Lukas Wagner
2025-09-03 8:59 ` Wolfgang Bumiller
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-yew-comp 1/2] apt view: allow to set task_base_url Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-yew-comp 2/2] apt view: reload if base urls have changed Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-datacenter-manager 1/4] server: add api for getting available updates/changelogs for remote nodes Lukas Wagner
2025-09-03 8:42 ` Lukas Wagner
2025-09-03 9:02 ` Stefan Hanreich
2025-09-03 9:19 ` Stefan Hanreich
2025-09-03 9:23 ` Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/4] ui: pve: promote node.rs to dir-style module Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-datacenter-manager 3/4] ui: pve: move node overview to a new overview tab Lukas Wagner
2025-09-03 9:10 ` Stefan Hanreich
2025-09-03 9:48 ` Lukas Wagner
2025-09-03 9:52 ` Stefan Hanreich
2025-09-03 9:55 ` Lukas Wagner
2025-09-02 15:14 ` [pdm-devel] [PATCH proxmox-datacenter-manager 4/4] ui: pve: node: add update tab Lukas Wagner
2025-09-03 10:20 ` [pdm-devel] [PATCH manager/proxmox{-api-types, -yew-comp, -datacenter-manager} 00/10] PVE node update view Stefan Hanreich
2025-09-03 11:43 ` [pdm-devel] superseded: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902151427.425017-3-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox