From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v3 1/9] pdm-api-types: resources: add helper methods for fields
Date: Tue, 26 Aug 2025 14:31:17 +0200 [thread overview]
Message-ID: <20250826123336.3970108-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250826123336.3970108-1-d.csapak@proxmox.com>
namely 'resource_type' and 'status'. All resources have those fields
in one way or another, so adding a helper that one does not have to
use `match` on every call site makes code there shorter.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
lib/pdm-api-types/src/resource.rs | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/lib/pdm-api-types/src/resource.rs b/lib/pdm-api-types/src/resource.rs
index 6227855..0dfadd5 100644
--- a/lib/pdm-api-types/src/resource.rs
+++ b/lib/pdm-api-types/src/resource.rs
@@ -62,6 +62,33 @@ impl Resource {
Resource::PbsDatastore(r) => r.name.as_str(),
}
}
+
+ pub fn resource_type(&self) -> &str {
+ match self {
+ Resource::PveStorage(_) => "storage",
+ Resource::PveQemu(_) => "qemu",
+ Resource::PveLxc(_) => "lxc",
+ Resource::PveNode(_) | Resource::PbsNode(_) => "node",
+ Resource::PbsDatastore(_) => "datastore",
+ }
+ }
+
+ pub fn status(&self) -> &str {
+ match self {
+ Resource::PveStorage(r) => r.status.as_str(),
+ Resource::PveQemu(r) => r.status.as_str(),
+ Resource::PveLxc(r) => r.status.as_str(),
+ Resource::PveNode(r) => r.status.as_str(),
+ Resource::PbsNode(r) => {
+ if r.uptime > 0 {
+ "online"
+ } else {
+ "offline"
+ }
+ }
+ Resource::PbsDatastore(_) => "online",
+ }
+ }
}
#[api(
--
2.47.2
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-08-26 12:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 12:31 [pdm-devel] [PATCH datacenter-manager v3 0/9] implement more complex search syntax Dominik Csapak
2025-08-26 12:31 ` Dominik Csapak [this message]
2025-08-26 12:31 ` [pdm-devel] [PATCH datacenter-manager v3 2/9] lib: add pdm-search crate Dominik Csapak
2025-08-27 9:12 ` Lukas Wagner
2025-08-26 12:31 ` [pdm-devel] [PATCH datacenter-manager v3 3/9] server: api: resources: add more complex filter syntax Dominik Csapak
2025-08-27 9:15 ` Lukas Wagner
2025-08-27 9:33 ` Stefan Hanreich
2025-08-27 20:15 ` Thomas Lamprecht
2025-08-26 12:31 ` [pdm-devel] [PATCH datacenter-manager v3 4/9] ui: add possibility to insert into search box Dominik Csapak
2025-08-26 12:31 ` [pdm-devel] [PATCH datacenter-manager v3 5/9] ui: dashboard: remotes panel: open search on click Dominik Csapak
2025-08-27 9:37 ` Lukas Wagner
2025-08-28 8:54 ` Dominik Csapak
2025-08-26 12:31 ` [pdm-devel] [PATCH datacenter-manager v3 6/9] ui: dashboard: guest panel: search for guest states when clicking on them Dominik Csapak
2025-08-26 12:31 ` [pdm-devel] [PATCH datacenter-manager v3 7/9] ui: dashboard: search for nodes when clicking on the nodes panel Dominik Csapak
2025-08-26 12:31 ` [pdm-devel] [PATCH datacenter-manager v3 8/9] ui: search box: add clear trigger Dominik Csapak
2025-08-26 12:31 ` [pdm-devel] [PATCH datacenter-manager v3 9/9] ui: dashboard: guest panel: improve column widths Dominik Csapak
2025-08-26 14:22 ` [pdm-devel] [PATCH datacenter-manager v3 0/9] implement more complex search syntax Stefan Hanreich
2025-08-28 13:21 ` [pdm-devel] superseded: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826123336.3970108-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox