public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v3 04/23] server: add probe-tls endpoint
Date: Thu, 21 Aug 2025 10:39:25 +0200	[thread overview]
Message-ID: <20250821084229.1523597-5-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250821084229.1523597-1-d.csapak@proxmox.com>

so that we can probe pve endpoints regarding fingerprint/certificate
validity

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 server/src/api/pve/mod.rs | 36 ++++++++++++++++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

diff --git a/server/src/api/pve/mod.rs b/server/src/api/pve/mod.rs
index 1a3a725..c03d352 100644
--- a/server/src/api/pve/mod.rs
+++ b/server/src/api/pve/mod.rs
@@ -13,7 +13,7 @@ use proxmox_schema::property_string::PropertyString;
 use proxmox_section_config::typed::SectionConfigData;
 use proxmox_sortable_macro::sortable;
 
-use pdm_api_types::remotes::{NodeUrl, Remote, RemoteType, REMOTE_ID_SCHEMA};
+use pdm_api_types::remotes::{NodeUrl, Remote, RemoteType, TlsProbeOutcome, REMOTE_ID_SCHEMA};
 use pdm_api_types::resource::PveResource;
 use pdm_api_types::{
     Authid, RemoteUpid, HOST_OPTIONAL_PORT_FORMAT, PRIV_RESOURCE_AUDIT, PRIV_RESOURCE_DELETE,
@@ -27,8 +27,8 @@ use pve_api_types::{ClusterResourceKind, ClusterResourceType};
 
 use super::resources::{map_pve_lxc, map_pve_node, map_pve_qemu, map_pve_storage};
 
-use crate::connection;
 use crate::connection::PveClient;
+use crate::connection::{self, probe_tls_connection};
 use crate::remote_tasks;
 
 mod lxc;
@@ -44,6 +44,7 @@ pub const ROUTER: Router = Router::new()
 #[sortable]
 const SUBDIRS: SubdirMap = &sorted!([
     ("remotes", &REMOTES_ROUTER),
+    ("probe-tls", &Router::new().post(&API_METHOD_PROBE_TLS)),
     ("scan", &Router::new().post(&API_METHOD_SCAN_REMOTE_PVE)),
     (
         "realms",
@@ -299,6 +300,37 @@ fn check_guest_delete_perms(
     )
 }
 
+#[api(
+    input: {
+        properties: {
+            hostname: {
+                type: String,
+                format: &HOST_OPTIONAL_PORT_FORMAT,
+                description: "Hostname (with optional port) of the target remote",
+            },
+            fingerprint: {
+                type: String,
+                description: "Fingerprint of the target remote.",
+                optional: true,
+            },
+        },
+    },
+    access: {
+        permission:
+            &Permission::Privilege(&["/"], PRIV_SYS_MODIFY, false),
+    },
+)]
+/// Probe the hosts TLS certificate.
+///
+/// If the certificate is not trusted with the given parameters, returns the certificate
+/// information.
+async fn probe_tls(
+    hostname: String,
+    fingerprint: Option<String>,
+) -> Result<TlsProbeOutcome, Error> {
+    probe_tls_connection(RemoteType::Pve, hostname, fingerprint).await
+}
+
 #[api(
     input: {
         properties: {
-- 
2.47.2



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-08-21  8:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21  8:39 [pdm-devel] [PATCH datacenter-manager v3 00/23] ] improve remote wizard Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 01/23] server/ui: pve: change 'realm list' api call to GET Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 02/23] api types: RemoteType: put default port info to the type Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 03/23] server: connection: add probe_tls_connection helper Dominik Csapak
2025-08-21 11:46   ` Lukas Wagner
2025-08-21  8:39 ` Dominik Csapak [this message]
2025-08-21 11:46   ` [pdm-devel] [PATCH datacenter-manager v3 04/23] server: add probe-tls endpoint Lukas Wagner
2025-08-21 11:55     ` Dominik Csapak
2025-08-21 11:58       ` Lukas Wagner
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 05/23] server: pve api: extend 'scan' so it tls-probes the nodes Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 06/23] pdm-client: add scan_remote and probe_tls methods Dominik Csapak
2025-08-21 11:46   ` Lukas Wagner
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 07/23] ui: remotes: node url list: add placeholder and clear trigger Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 08/23] ui: remotes: node url list: make column header clearer Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 09/23] ui: remotes: node url list: handle changing default Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 10/23] ui: pve wizard: rename 'realm' variable to 'info' Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 11/23] ui: pve wizard: summary: add default text for fingerprint Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 12/23] ui: pve wizard: nodes: improve info text Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 13/23] ui: pve wizard: nodes: probe hosts to verify fingerprint settings Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 14/23] ui: pve wizard: info: use pdm_client for scanning Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 15/23] ui: pve wizard: info: detect hostname and fingerprint Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 16/23] ui: pve wizard: info: remove manual scan button Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 17/23] ui: widget: add pve realm selector Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 18/23] ui: pve wizard: info: use " Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 19/23] ui: pve wizard: connect: factor out normalize_hostname Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 20/23] ui: pve wizard: connect: move connection logic to next button Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 21/23] ui: pve wizard: connect: reset later pages when form changes Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 22/23] ui: pve wizard: connect: use scan api endpoint instead of realms Dominik Csapak
2025-08-21  8:39 ` [pdm-devel] [PATCH datacenter-manager v3 23/23] ui: pve wizard: connect: add certificate confirmation dialog Dominik Csapak
2025-08-21 11:45 ` [pdm-devel] [PATCH datacenter-manager v3 00/23] ] improve remote wizard Lukas Wagner
2025-08-22  8:10   ` Thomas Lamprecht
2025-08-22  9:03 ` [pdm-devel] superseded: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250821084229.1523597-5-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal