From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager/yew-comp 0/2] refactor status structs and Fa interaction
Date: Wed, 30 Apr 2025 09:29:34 +0200 [thread overview]
Message-ID: <20250430072936.447054-1-d.csapak@proxmox.com> (raw)
Instead of having a 'to_fa_icon' for the status structs, implement
From. This is more idiomatic rust, and makes for nicer code.
proxmox-yew-comp:
Dominik Csapak (1):
status: replace `to_fa_icon` with From implementation
src/status.rs | 64 ++++++++++++++++++++++++++++++++++++++++++++-------
1 file changed, 56 insertions(+), 8 deletions(-)
proxmox-datacenter-manager:
Dominik Csapak (1):
ui: adapt to deprecation of `to_fa_icon`
ui/src/dashboard/guest_panel.rs | 2 +-
ui/src/dashboard/mod.rs | 15 +++++++--------
ui/src/dashboard/remote_panel.rs | 6 +++---
ui/src/dashboard/subscription_info.rs | 2 +-
ui/src/pve/remote.rs | 4 ++--
ui/src/pve/utils.rs | 12 +++++-------
ui/src/remotes/node_url_list.rs | 4 ++--
ui/src/widget/migrate_window.rs | 6 +++---
ui/src/widget/pve_node_selector.rs | 4 ++--
ui/src/widget/resource_tree.rs | 13 ++++---------
10 files changed, 30 insertions(+), 38 deletions(-)
Summary over all repositories:
11 files changed, 86 insertions(+), 46 deletions(-)
--
Generated by git-murpp 0.8.1
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next reply other threads:[~2025-04-30 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 7:29 Dominik Csapak [this message]
2025-04-30 7:29 ` [pdm-devel] [PATCH yew-comp 1/1] status: replace `to_fa_icon` with From implementation Dominik Csapak
2025-04-30 9:24 ` [pdm-devel] applied: [PATCH yew-comp 1/1] status: replace `to_fa_icon` with From implementatio Dietmar Maurer
2025-04-30 7:29 ` [pdm-devel] [PATCH datacenter-manager 1/1] ui: adapt to deprecation of `to_fa_icon` Dominik Csapak
2025-05-06 11:40 ` [pdm-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250430072936.447054-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal