public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager v4 6/6] fake remote: clippy fixes
Date: Fri, 18 Apr 2025 10:32:10 +0200	[thread overview]
Message-ID: <20250418083210.74982-7-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250418083210.74982-1-l.wagner@proxmox.com>

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---

Notes:
    Added in v3

 server/src/test_support/fake_remote.rs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/server/src/test_support/fake_remote.rs b/server/src/test_support/fake_remote.rs
index 840c2131..37c1992a 100644
--- a/server/src/test_support/fake_remote.rs
+++ b/server/src/test_support/fake_remote.rs
@@ -132,7 +132,7 @@ impl pve_api_types::client::PveClient for FakePveClient {
         let mut vmid = 100;
 
         for _ in 0..self.nr_of_vms {
-            vmid = vmid + 1;
+            vmid += 1;
             result.push(ClusterResource {
                 cgroup_mode: None,
                 content: None,
@@ -165,7 +165,7 @@ impl pve_api_types::client::PveClient for FakePveClient {
         }
 
         for _ in 0..self.nr_of_cts {
-            vmid = vmid + 1;
+            vmid += 1;
             result.push(ClusterResource {
                 cgroup_mode: None,
                 content: None,
@@ -357,7 +357,6 @@ impl pve_api_types::client::PveClient for FakePveClient {
     async fn list_nodes(&self) -> Result<Vec<ClusterNodeIndexResponse>, proxmox_client::Error> {
         tokio::time::sleep(Duration::from_millis(self.api_delay_ms as u64)).await;
         Ok((0..self.nr_of_nodes)
-            .into_iter()
             .map(|i| ClusterNodeIndexResponse {
                 node: format!("pve-{i}"),
                 cpu: None,
@@ -414,7 +413,6 @@ impl pve_api_types::client::PveClient for FakePveClient {
         let number_of_tasks = limit.min(number_of_tasks as u64);
 
         Ok((0..number_of_tasks)
-            .into_iter()
             .map(|i| make_task(now - i as i64 * NEW_TASK_EVERY * 60))
             .collect())
     }
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-04-18  8:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18  8:32 [pdm-devel] [PATCH proxmox-datacenter-manager v4 0/6] remote task cache fetching task / better cache backend Lukas Wagner
2025-04-18  8:32 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 1/6] remote tasks: implement improved cache for remote tasks Lukas Wagner
2025-04-18  8:32 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 2/6] remote tasks: add background task for task polling, use new task cache Lukas Wagner
2025-04-18  8:32 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 3/6] remote tasks: improve locking for task archive iterator Lukas Wagner
2025-04-18  8:32 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 4/6] pdm-api-types: remote tasks: add new_from_str constructor for TaskStateType Lukas Wagner
2025-04-18  8:32 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 5/6] fake remote: make the fake_remote feature compile again Lukas Wagner
2025-04-18  8:32 ` Lukas Wagner [this message]
2025-05-12 11:44 ` [pdm-devel] superseded: [PATCH proxmox-datacenter-manager v4 0/6] remote task cache fetching task / better cache backend Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250418083210.74982-7-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal