public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager v4 5/6] fake remote: make the fake_remote feature compile again
Date: Fri, 18 Apr 2025 10:32:09 +0200	[thread overview]
Message-ID: <20250418083210.74982-6-l.wagner@proxmox.com> (raw)
In-Reply-To: <20250418083210.74982-1-l.wagner@proxmox.com>

The ClientFactory trait was changed in Wolfgang's multi-client patches,
this commit adapts the fake remote feature to the changes.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---

Notes:
    new in v2

 server/src/test_support/fake_remote.rs | 29 +++++++++++++-------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/server/src/test_support/fake_remote.rs b/server/src/test_support/fake_remote.rs
index 40f68807..840c2131 100644
--- a/server/src/test_support/fake_remote.rs
+++ b/server/src/test_support/fake_remote.rs
@@ -1,18 +1,22 @@
-use std::{collections::HashMap, time::Duration};
+use std::{collections::HashMap, sync::Arc, time::Duration};
 
 use anyhow::{bail, Error};
+use serde::Deserialize;
+
 use pdm_api_types::{remotes::Remote, Authid, ConfigDigest};
 use pdm_config::remotes::RemoteConfig;
 use proxmox_product_config::ApiLockGuard;
 use proxmox_section_config::typed::SectionConfigData;
 use pve_api_types::{
-    client::PveClient, ClusterMetrics, ClusterMetricsData, ClusterNodeIndexResponse,
-    ClusterNodeIndexResponseStatus, ClusterResource, ClusterResourceKind, ClusterResourceType,
-    ListTasks, ListTasksResponse, PveUpid, StorageContent,
+    ClusterMetrics, ClusterMetricsData, ClusterNodeIndexResponse, ClusterNodeIndexResponseStatus,
+    ClusterResource, ClusterResourceKind, ClusterResourceType, ListTasks, ListTasksResponse,
+    PveUpid, StorageContent,
 };
-use serde::Deserialize;
 
-use crate::{connection::ClientFactory, pbs_client::PbsClient};
+use crate::{
+    connection::{ClientFactory, PveClient},
+    pbs_client::PbsClient,
+};
 
 #[derive(Deserialize, Clone)]
 #[serde(rename_all = "kebab-case")]
@@ -77,8 +81,8 @@ impl FakeRemoteConfig {
 
 #[async_trait::async_trait]
 impl ClientFactory for FakeClientFactory {
-    fn make_pve_client(&self, _remote: &Remote) -> Result<Box<dyn PveClient + Send + Sync>, Error> {
-        Ok(Box::new(FakePveClient {
+    fn make_pve_client(&self, _remote: &Remote) -> Result<Arc<PveClient>, Error> {
+        Ok(Arc::new(FakePveClient {
             nr_of_vms: self.config.vms_per_pve_remote,
             nr_of_cts: self.config.cts_per_pve_remote,
             nr_of_nodes: self.config.nodes_per_pve_remote,
@@ -91,7 +95,7 @@ impl ClientFactory for FakeClientFactory {
         &self,
         _remote: &Remote,
         _target_endpoint: Option<&str>,
-    ) -> Result<Box<dyn PveClient + Send + Sync>, Error> {
+    ) -> Result<Arc<PveClient>, Error> {
         bail!("not implemented")
     }
 
@@ -99,10 +103,7 @@ impl ClientFactory for FakeClientFactory {
         bail!("not implemented")
     }
 
-    async fn make_pve_client_and_login(
-        &self,
-        _remote: &Remote,
-    ) -> Result<Box<dyn PveClient + Send + Sync>, Error> {
+    async fn make_pve_client_and_login(&self, _remote: &Remote) -> Result<Arc<PveClient>, Error> {
         bail!("not implemented")
     }
 
@@ -121,7 +122,7 @@ struct FakePveClient {
 }
 
 #[async_trait::async_trait]
-impl PveClient for FakePveClient {
+impl pve_api_types::client::PveClient for FakePveClient {
     async fn cluster_resources(
         &self,
         _ty: Option<ClusterResourceKind>,
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-04-18  8:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18  8:32 [pdm-devel] [PATCH proxmox-datacenter-manager v4 0/6] remote task cache fetching task / better cache backend Lukas Wagner
2025-04-18  8:32 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 1/6] remote tasks: implement improved cache for remote tasks Lukas Wagner
2025-04-18  8:32 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 2/6] remote tasks: add background task for task polling, use new task cache Lukas Wagner
2025-04-18  8:32 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 3/6] remote tasks: improve locking for task archive iterator Lukas Wagner
2025-04-18  8:32 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 4/6] pdm-api-types: remote tasks: add new_from_str constructor for TaskStateType Lukas Wagner
2025-04-18  8:32 ` Lukas Wagner [this message]
2025-04-18  8:32 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 6/6] fake remote: clippy fixes Lukas Wagner
2025-05-12 11:44 ` [pdm-devel] superseded: [PATCH proxmox-datacenter-manager v4 0/6] remote task cache fetching task / better cache backend Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250418083210.74982-6-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal