From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v2] server: api: resources: handle template in status count
Date: Fri, 18 Apr 2025 08:15:16 +0200 [thread overview]
Message-ID: <20250418061516.259333-1-d.csapak@proxmox.com> (raw)
Originally, the PVE API schema description did not include the template
flag (so the information was not present in the rust types), and after
adding it, we forgot to update this part of the code to count the
templates correctly.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* add commit message to explain why we do this now
server/src/api/resources.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
index 453d9e8..ddcee7e 100644
--- a/server/src/api/resources.rs
+++ b/server/src/api/resources.rs
@@ -191,14 +191,14 @@ pub async fn get_status(
_ => counts.storages.unknown += 1,
},
Resource::PveQemu(r) => match r.status.as_str() {
+ _ if r.template => counts.qemu.template += 1,
"running" => counts.qemu.running += 1,
- // FIXME: handle templates
"stopped" => counts.qemu.stopped += 1,
_ => counts.qemu.unknown += 1,
},
Resource::PveLxc(r) => match r.status.as_str() {
+ _ if r.template => counts.lxc.template += 1,
"running" => counts.lxc.running += 1,
- // FIXME: handle templates
"stopped" => counts.lxc.stopped += 1,
_ => counts.lxc.unknown += 1,
},
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next reply other threads:[~2025-04-18 6:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 6:15 Dominik Csapak [this message]
2025-04-18 6:43 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418061516.259333-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal