[pdm-devel] [PATCH datacenter-manager] server: api: resources: handle template in status count

[pdm-devel] [PATCH datacenter-manager] server: api: resources: handle template in status count

[Dominik Csapak]

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 server/src/api/resources.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
index 453d9e8..ddcee7e 100644
--- a/server/src/api/resources.rs
+++ b/server/src/api/resources.rs
@@ -191,14 +191,14 @@ pub async fn get_status(
                     _ => counts.storages.unknown += 1,
                 },
                 Resource::PveQemu(r) => match r.status.as_str() {
+                    _ if r.template => counts.qemu.template += 1,
                     "running" => counts.qemu.running += 1,
-                    // FIXME: handle templates
                     "stopped" => counts.qemu.stopped += 1,
                     _ => counts.qemu.unknown += 1,
                 },
                 Resource::PveLxc(r) => match r.status.as_str() {
+                    _ if r.template => counts.lxc.template += 1,
                     "running" => counts.lxc.running += 1,
-                    // FIXME: handle templates
                     "stopped" => counts.lxc.stopped += 1,
                     _ => counts.lxc.unknown += 1,
                 },
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] server: api: resources: handle template in status count

[Thomas Lamprecht]

Seems simple enough, but the existences of the FIXME comments warrant
and actual commit message, i.e. why wasn't this done earlier already
if it's so simple? And FWIW, a short message would not hurt in any way.

Am 16.04.25 um 13:31 schrieb Dominik Csapak:
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  server/src/api/resources.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
> index 453d9e8..ddcee7e 100644
> --- a/server/src/api/resources.rs
> +++ b/server/src/api/resources.rs
> @@ -191,14 +191,14 @@ pub async fn get_status(
>                      _ => counts.storages.unknown += 1,
>                  },
>                  Resource::PveQemu(r) => match r.status.as_str() {
> +                    _ if r.template => counts.qemu.template += 1,
>                      "running" => counts.qemu.running += 1,
> -                    // FIXME: handle templates
>                      "stopped" => counts.qemu.stopped += 1,
>                      _ => counts.qemu.unknown += 1,
>                  },
>                  Resource::PveLxc(r) => match r.status.as_str() {
> +                    _ if r.template => counts.lxc.template += 1,
>                      "running" => counts.lxc.running += 1,
> -                    // FIXME: handle templates
>                      "stopped" => counts.lxc.stopped += 1,
>                      _ => counts.lxc.unknown += 1,
>                  },



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] server: api: resources: handle template in status count

[Dominik Csapak]

On 4/17/25 17:38, Thomas Lamprecht wrote:
> Seems simple enough, but the existences of the FIXME comments warrant
> and actual commit message, i.e. why wasn't this done earlier already
> if it's so simple? And FWIW, a short message would not hurt in any way.
> 

ah yes, sorry.

For the longest time we did not get the info about templates from the api because
the pve return description for that was missing. And after we added
that, nobody updated this code to handle the new fields.

I'll send a v2 with that explanation in the commit message

> Am 16.04.25 um 13:31 schrieb Dominik Csapak:
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   server/src/api/resources.rs | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
>> index 453d9e8..ddcee7e 100644
>> --- a/server/src/api/resources.rs
>> +++ b/server/src/api/resources.rs
>> @@ -191,14 +191,14 @@ pub async fn get_status(
>>                       _ => counts.storages.unknown += 1,
>>                   },
>>                   Resource::PveQemu(r) => match r.status.as_str() {
>> +                    _ if r.template => counts.qemu.template += 1,
>>                       "running" => counts.qemu.running += 1,
>> -                    // FIXME: handle templates
>>                       "stopped" => counts.qemu.stopped += 1,
>>                       _ => counts.qemu.unknown += 1,
>>                   },
>>                   Resource::PveLxc(r) => match r.status.as_str() {
>> +                    _ if r.template => counts.lxc.template += 1,
>>                       "running" => counts.lxc.running += 1,
>> -                    // FIXME: handle templates
>>                       "stopped" => counts.lxc.stopped += 1,
>>                       _ => counts.lxc.unknown += 1,
>>                   },
> 



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] server: api: resources: handle template in status count

[Thomas Lamprecht]

Am 18.04.25 um 08:12 schrieb Dominik Csapak:
> For the longest time we did not get the info about templates from the api because
> the pve return description for that was missing. And after we added
> that, nobody updated this code to handle the new fields.
> 
> I'll send a v2 with that explanation in the commit message

Thanks, mentioning the respective repo & commit references would be
also appreciated then.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] server: api: resources: handle template in status count

[Dominik Csapak]

superseded by v3:
https://lore.proxmox.com/pdm-devel/20250418064250.622118-1-d.csapak@proxmox.com/


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel