public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 1/1] ui: remote tasks: add loading animation for running tasks
Date: Tue, 18 Mar 2025 15:32:52 +0100	[thread overview]
Message-ID: <20250318143252.3531503-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250318143252.3531503-1-d.csapak@proxmox.com>

when there is no endtime and the status is either empty or "RUNNING"
(for PVE), render a spinning loading icon, like we do in the ExtJS UI.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/remotes/tasks.rs | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/ui/src/remotes/tasks.rs b/ui/src/remotes/tasks.rs
index 99bb243..ef9a8bf 100644
--- a/ui/src/remotes/tasks.rs
+++ b/ui/src/remotes/tasks.rs
@@ -20,7 +20,7 @@ use pwt::{
     tr,
     widget::{
         data_table::{DataTableColumn, DataTableHeader},
-        Column,
+        Column, Fa, Row,
     },
 };
 
@@ -47,7 +47,11 @@ fn columns() -> Rc<Vec<DataTableHeader<TaskListItem>>> {
             .width("130px")
             .render(|item: &TaskListItem| match item.endtime {
                 Some(endtime) => render_epoch_short(endtime).into(),
-                None => html! {},
+                None => Row::new()
+                    .with_flex_spacer()
+                    .with_child(Fa::new("").class("pwt-loading-icon"))
+                    .with_flex_spacer()
+                    .into(),
             })
             .into(),
         DataTableColumn::new(tr!("User name"))
@@ -91,7 +95,14 @@ fn columns() -> Rc<Vec<DataTableHeader<TaskListItem>>> {
             .width("minmax(200px, 1fr)")
             .render(|item: &TaskListItem| {
                 let text = item.status.as_deref().unwrap_or("");
-                html! {text}
+                match text {
+                    "" | "RUNNING" => Row::new()
+                        .with_flex_spacer()
+                        .with_child(Fa::new("").class("pwt-loading-icon"))
+                        .with_flex_spacer()
+                        .into(),
+                    text => html! {text},
+                }
             })
             .into(),
     ])
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      parent reply	other threads:[~2025-03-18 14:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18 14:32 [pdm-devel] [PATCH yew-comp/datacenter-manager] improve rendering " Dominik Csapak
2025-03-18 14:32 ` [pdm-devel] [PATCH yew-comp 1/2] tasks: don't mark running tasks from pve with 'error' color Dominik Csapak
2025-03-20  6:25   ` Dietmar Maurer
2025-03-20  8:10     ` Dominik Csapak
2025-03-20  9:03       ` [pdm-devel] applied: " Dietmar Maurer
2025-03-18 14:32 ` [pdm-devel] [PATCH yew-comp 2/2] tasks: add loading animation for running tasks Dominik Csapak
2025-03-20  9:08   ` Dietmar Maurer
2025-03-18 14:32 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250318143252.3531503-4-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal