From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp 2/2] tasks: add loading animation for running tasks
Date: Tue, 18 Mar 2025 15:32:51 +0100 [thread overview]
Message-ID: <20250318143252.3531503-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250318143252.3531503-1-d.csapak@proxmox.com>
when there is no endtime and the status is either empty or "RUNNING"
(for PVE), render a spinning loading icon, like we do in the ExtJS UI.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/tasks.rs | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/src/tasks.rs b/src/tasks.rs
index 499f5b9..1d3b0bf 100644
--- a/src/tasks.rs
+++ b/src/tasks.rs
@@ -17,7 +17,7 @@ use pwt::state::{PersistentState, Selection, Store};
use pwt::widget::data_table::{
DataTable, DataTableColumn, DataTableHeader, DataTableRowRenderCallback,
};
-use pwt::widget::{Button, Column, Toolbar};
+use pwt::widget::{Button, Column, Fa, Row, Toolbar};
use crate::utils::{format_upid, render_epoch_short};
@@ -122,7 +122,11 @@ impl ProxmoxTasks {
.width("130px")
.render(|item: &TaskListItem| match item.endtime {
Some(endtime) => render_epoch_short(endtime).into(),
- None => html! {},
+ None => Row::new()
+ .with_flex_spacer()
+ .with_child(Fa::new("").class("pwt-loading-icon"))
+ .with_flex_spacer()
+ .into(),
})
.into(),
DataTableColumn::new(tr!("User name"))
@@ -139,7 +143,14 @@ impl ProxmoxTasks {
.width("200px")
.render(|item: &TaskListItem| {
let text = item.status.as_deref().unwrap_or("");
- html! {text}
+ match text {
+ "" | "RUNNING" => Row::new()
+ .with_flex_spacer()
+ .with_child(Fa::new("").class("pwt-loading-icon"))
+ .with_flex_spacer()
+ .into(),
+ text => html! {text},
+ }
})
.into(),
])
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-03-18 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 14:32 [pdm-devel] [PATCH yew-comp/datacenter-manager] improve rendering " Dominik Csapak
2025-03-18 14:32 ` [pdm-devel] [PATCH yew-comp 1/2] tasks: don't mark running tasks from pve with 'error' color Dominik Csapak
2025-03-20 6:25 ` Dietmar Maurer
2025-03-20 8:10 ` Dominik Csapak
2025-03-20 9:03 ` [pdm-devel] applied: " Dietmar Maurer
2025-03-18 14:32 ` Dominik Csapak [this message]
2025-03-20 9:08 ` [pdm-devel] [PATCH yew-comp 2/2] tasks: add loading animation for running tasks Dietmar Maurer
2025-03-18 14:32 ` [pdm-devel] [PATCH datacenter-manager 1/1] ui: remote " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318143252.3531503-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal