From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp 1/2] tasks: don't mark running tasks from pve with 'error' color
Date: Tue, 18 Mar 2025 15:32:50 +0100 [thread overview]
Message-ID: <20250318143252.3531503-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250318143252.3531503-1-d.csapak@proxmox.com>
running tasks from the PVE tasks API have 'RUNNING' in their status
field (in contrast to e.g. the PBS API) instead of nothing. To not mark
them with an error color, we have to make an exception for this here.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/tasks.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tasks.rs b/src/tasks.rs
index 1b65c8e..499f5b9 100644
--- a/src/tasks.rs
+++ b/src/tasks.rs
@@ -172,7 +172,7 @@ impl LoadableComponent for ProxmoxTasks {
if status != "OK" {
if status.starts_with("WARNINGS:") {
args.add_class("pwt-color-warning");
- } else {
+ } else if status != "RUNNING" {
args.add_class("pwt-color-error");
}
}
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-03-18 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 14:32 [pdm-devel] [PATCH yew-comp/datacenter-manager] improve rendering running tasks Dominik Csapak
2025-03-18 14:32 ` Dominik Csapak [this message]
2025-03-20 6:25 ` [pdm-devel] [PATCH yew-comp 1/2] tasks: don't mark running tasks from pve with 'error' color Dietmar Maurer
2025-03-20 8:10 ` Dominik Csapak
2025-03-20 9:03 ` [pdm-devel] applied: " Dietmar Maurer
2025-03-18 14:32 ` [pdm-devel] [PATCH yew-comp 2/2] tasks: add loading animation for running tasks Dominik Csapak
2025-03-20 9:08 ` Dietmar Maurer
2025-03-18 14:32 ` [pdm-devel] [PATCH datacenter-manager 1/1] ui: remote " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318143252.3531503-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal