Re: [pdm-devel] [PATCH proxmox 2/2] pve api types: add cluster options api call

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 28.11.25 um 11:18 schrieb Dominik Csapak:
> so we can get e.g. the datacenter notes.
> 
> The return schema for this is currently not defined and adding it in
> pve-manager is rather hard.
> 
> The reason for this is that while we have defined the datacenter config
> schema for the update call, the properties are all property-strings. In
> the GET call however, we parse these and return a nested object.
>
> We'd either have to copy the whole schema and make sure it does not
> diverge, or find some more elegant way to modify the return schema to

That's not really different to now, nothing really protects us from the
schema changing and then a type not working for older APIs. As of now,
this needs explicit handling either way if anything changes.

And if we would add support for understanding this, then it would not
get really harder to start tracking different versions of the schema
(pve-api-v8.json) and diff them to see what types also need to be
generated in a v8 variant, like we plan for the long run, as that's
rather unrelated from the actual generation itself.

> include the parsed properties (for some properties this even happens
> nested, e.g. a list in a property string gets split into an actual
> array).

Having (optional) support for this would be nice though, and we do have
all the info required for that on the PVE side. As not having to do two
deserialization steps with two different formats for getting the actual
data (json + parse-property-string) can be easily seen as feature.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel