From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pdm-devel@lists.proxmox.com
Subject: Re: [pdm-devel] applied: [PATCH datacenter-manager 1/1] ui: remote wizard: validate remote ID
Date: Wed, 29 Oct 2025 15:46:25 +0100 [thread overview]
Message-ID: <1b798f86-242e-4d6e-be09-cadce48b3c80@proxmox.com> (raw)
In-Reply-To: <6ee62e07-557a-4939-bbbe-0c0a5c3748b5@proxmox.com>
Am 29.10.25 um 15:20 schrieb Fiona Ebner:
> Am 29.10.25 um 3:13 PM schrieb Thomas Lamprecht:
>> On Wed, 29 Oct 2025 14:46:27 +0100, Fiona Ebner wrote:
>> Tiny nit, but as I noticed it more than a few times now already:
>> Personally I'm not a big fan of cover-letters for simple single-patch
>> submissions, just adds noise. Basically I'd prefer:
>>
>> - single commit -> single patch and no cover letter, it's basically just a
>> `git send-email -1` call anyway.
>> - multiple commits -> always a cover letter.
>>
>> But if I'd have to chose between either always cover-letter or never I'd go for
>> always, so it's fine for me, just find it unnecessary and cost my slightly more
>> time to read a extra post to see if there is anything that special that
>> warrants a cover-letter for "just" a single patch.
>
> Okay, sorry. I recently switched to always using cover letters as part
> of my workflow (since I often don't know if something will stay a single
> patch or a single repo for that matter). But I'll switch back to sending
> only a stand-alone patch if it turned out to be that.
Nothing big, so definitively no worries, and if it helps you it has at
least a benefit for somebody, and with that it's fine for me.
I mostly want to avoid that others always send cover letters for single
patches just because they think it's required.
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-10-29 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 13:46 [pdm-devel] [PATCH datacenter-manager 0/1] " Fiona Ebner
2025-10-29 13:46 ` [pdm-devel] [PATCH datacenter-manager 1/1] " Fiona Ebner
2025-10-29 14:09 ` [pdm-devel] applied: " Thomas Lamprecht
2025-10-29 14:20 ` Fiona Ebner
2025-10-29 14:46 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b798f86-242e-4d6e-be09-cadce48b3c80@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox