From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: applied: [PATCH datacenter-manager] api: nodes: add explicit permission check for RRD data points endpoint
Date: Fri, 28 Aug 2026 12:59:21 +0200 [thread overview]
Message-ID: <178791476113.202257.7224668723822791393.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260827130033.131872-1-s.shaji@proxmox.com>
On Thu, 27 Aug 2026 15:00:33 +0200, Shan Shaji wrote:
> The /rrddata endpoint did not have the access parameter defined inside
> the API macro. This resulted in a "403: permission check failed" error
> in the UI even though the user was assigned the Administrator role on
> the / ACL path. This issue was raised in the forum [0].
>
> Fix this by adding the explicit permission check.
>
> [...]
Applied, with Thomas' R-b and T-b trailers added, thanks!
[1/1] api: nodes: add explicit permission check for RRD data points endpoint
commit: 14724450e0a8bf4841bbcd7843b903a0a923e4aa
Best regards,
--
Lukas Wagner <l.wagner@proxmox.com>
prev parent reply other threads:[~2026-08-28 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 13:00 [PATCH datacenter-manager] api: nodes: add explicit permission check for RRD data points endpoint Shan Shaji
2026-08-28 9:56 ` Thomas Ellmenreich
2026-08-28 10:59 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178791476113.202257.7224668723822791393.b4-ty@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox