From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 46AE41FF0DF for ; Fri, 28 Aug 2026 13:00:46 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BC777214D5; Fri, 28 Aug 2026 13:00:45 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com, Shan Shaji In-Reply-To: <20260827130033.131872-1-s.shaji@proxmox.com> References: <20260827130033.131872-1-s.shaji@proxmox.com> Subject: applied: [PATCH datacenter-manager] api: nodes: add explicit permission check for RRD data points endpoint Message-Id: <178791476113.202257.7224668723822791393.b4-ty@proxmox.com> Date: Fri, 28 Aug 2026 12:59:21 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787914832639 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.419 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QQ2AS2JRBZI7KSFRAMZG5OS7FTAOXNVJ X-Message-ID-Hash: QQ2AS2JRBZI7KSFRAMZG5OS7FTAOXNVJ X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 27 Aug 2026 15:00:33 +0200, Shan Shaji wrote: > The /rrddata endpoint did not have the access parameter defined inside > the API macro. This resulted in a "403: permission check failed" error > in the UI even though the user was assigned the Administrator role on > the / ACL path. This issue was raised in the forum [0]. > > Fix this by adding the explicit permission check. > > [...] Applied, with Thomas' R-b and T-b trailers added, thanks! [1/1] api: nodes: add explicit permission check for RRD data points endpoint commit: 14724450e0a8bf4841bbcd7843b903a0a923e4aa Best regards, -- Lukas Wagner