public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH datacenter-manager v3] ui: configuration: slightly clean up tool tips for subscrion registry
@ 2026-05-26 14:58 Shannon Sterz
  2026-05-27 16:01 ` applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Shannon Sterz @ 2026-05-26 14:58 UTC (permalink / raw)
  To: pdm-devel

* properly quote actions
* rephrase some tips slightly for clarity.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---

Notes:
    Changelog
    ---------
    
    since v2: rephrased `Auto-Assign` tool tip based on Thomas' and Lukas'
    suggestions.

 ui/src/configuration/subscription_keys.rs     | 8 ++++----
 ui/src/configuration/subscription_registry.rs | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
index 5f3e9aa..a4e63f8 100644
--- a/ui/src/configuration/subscription_keys.rs
+++ b/ui/src/configuration/subscription_keys.rs
@@ -286,7 +286,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
                         .on_activate(link.change_view_callback(|_| Some(ViewState::Add))),
                 )
                 .tip(tr!(
-                    "Add one or more subscription keys to the pool; the Assign step \
+                    "Add one or more subscription keys to the pool; the 'Assign' step \
                      happens later."
                 )),
             )
@@ -299,7 +299,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
                         .on_activate(link.change_view_callback(|_| Some(ViewState::Assign))),
                 )
                 .tip(tr!(
-                    "Pin the selected key to a remote node; Apply Pending pushes the \
+                    "Pin the selected key to a remote node; 'Apply Pending' pushes the \
                      assignment to the remote."
                 )),
             )
@@ -324,8 +324,8 @@ impl LoadableComponent for SubscriptionKeyGridComp {
                         .on_activate(move |_| cb.emit(())),
                 )
                 .tip(tr!(
-                    "Propose a one-key-per-node assignment for nodes that have no active \
-                     subscription, then queue it pending Apply."
+                    "Propose a key assignment for nodes that have no active subscription \
+                    then queue it for the next 'Apply Pending'."
                 )),
             );
         }
diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/configuration/subscription_registry.rs
index 45d8ccc..60cc43e 100644
--- a/ui/src/configuration/subscription_registry.rs
+++ b/ui/src/configuration/subscription_registry.rs
@@ -135,7 +135,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
                     .with_child(tr!("{n} pending push(es)", n = push_count)),
             )
             .tip(tr!(
-                "{n} pool key(s) queued for push; Apply Pending will install them on the remote.",
+                "{n} pool key(s) queued for push; 'Apply Pending' will install them on the remote.",
                 n = push_count,
             )),
         );
@@ -150,7 +150,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
                     .with_child(tr!("{n} pending clear(s)", n = clear_count)),
             )
             .tip(tr!(
-                "{n} live subscription(s) queued for removal; Apply Pending will free them.",
+                "{n} live subscription(s) queued for removal; 'Apply Pending' will free them.",
                 n = clear_count,
             )),
         );
@@ -739,7 +739,7 @@ fn key_cell(n: &RemoteNodeStatus) -> Html {
                         .with_child(text),
                 )
                 .tip(tr!(
-                    "Not in pool - Adopt Key imports this live subscription."
+                    "Not in pool - 'Adopt Key' imports this live subscription."
                 ))
                 .into()
             } else {
@@ -1374,7 +1374,7 @@ impl SubscriptionRegistryComp {
                 .on_activate(ctx.link().callback(|_| Msg::QueueClearForSelectedNode)),
         )
         .tip(tr!(
-            "Queue the selected node's live subscription for removal at the next Apply Pending, \
+            "Queue the selected node's live subscription for removal at the next 'Apply Pending', \
              freeing the key for reassignment. Available for a pool-managed node; for a foreign \
              subscription, adopt it first."
         ));
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* applied: [PATCH datacenter-manager v3] ui: configuration: slightly clean up tool tips for subscrion registry
  2026-05-26 14:58 [PATCH datacenter-manager v3] ui: configuration: slightly clean up tool tips for subscrion registry Shannon Sterz
@ 2026-05-27 16:01 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-05-27 16:01 UTC (permalink / raw)
  To: pdm-devel, Shannon Sterz

On Tue, 26 May 2026 16:58:06 +0200, Shannon Sterz wrote:
> * properly quote actions
> * rephrase some tips slightly for clarity.

Applied, thanks!

[1/1] ui: configuration: slightly clean up tool tips for subscrion registry
      commit: 6c4dcdd721eef3386a7be4a38de8a5bfb781762d




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-27 16:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-26 14:58 [PATCH datacenter-manager v3] ui: configuration: slightly clean up tool tips for subscrion registry Shannon Sterz
2026-05-27 16:01 ` applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal