From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com, Hannes Laimer <h.laimer@proxmox.com>
Subject: applied: [PATCH datacenter-manager v2] ui: auto-installer: align network-tab with disks-tab
Date: Wed, 27 May 2026 10:02:53 +0200 [thread overview]
Message-ID: <177986895220.785749.2999021210719099496.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260527075606.40696-1-h.laimer@proxmox.com>
On Wed, 27 May 2026 09:56:06 +0200, Hannes Laimer wrote:
> We don't show the advanced checkbox, so having the filter in the
> advanced section will always have it hidden. This prevents submitting
> cause the filter is required for static ip configurations. The disks
> form has the same scenario, "advanced filtering" required based on form
> input.
>
> Not having it in advanced also makes sense cause advanced usually
> implies optionality, which this is very much not for static, and for
> dhcp this filter is ignored by the installer.
>
> [...]
Applied, thanks!
[1/1] ui: auto-installer: align network-tab with disks-tab
commit: a52f563f73228d9ef7b2c2fe6bae3403c065bacf
prev parent reply other threads:[~2026-05-27 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 7:56 [PATCH datacenter-manager v2] ui: auto-installer: align network-tab with disks-tab Hannes Laimer
2026-05-27 8:02 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177986895220.785749.2999021210719099496.b4-ty@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox