From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F36081FF13A for ; Wed, 27 May 2026 10:03:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 159D012B7D; Wed, 27 May 2026 10:03:06 +0200 (CEST) From: Dominik Csapak To: pdm-devel@lists.proxmox.com, Hannes Laimer Subject: applied: [PATCH datacenter-manager v2] ui: auto-installer: align network-tab with disks-tab Date: Wed, 27 May 2026 10:02:53 +0200 Message-ID: <177986895220.785749.2999021210719099496.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260527075606.40696-1-h.laimer@proxmox.com> References: <20260527075606.40696-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: A72722EJPOQNPQONJZACHEM42EQZUTGO X-Message-ID-Hash: A72722EJPOQNPQONJZACHEM42EQZUTGO X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 27 May 2026 09:56:06 +0200, Hannes Laimer wrote: > We don't show the advanced checkbox, so having the filter in the > advanced section will always have it hidden. This prevents submitting > cause the filter is required for static ip configurations. The disks > form has the same scenario, "advanced filtering" required based on form > input. > > Not having it in advanced also makes sense cause advanced usually > implies optionality, which this is very much not for static, and for > dhcp this filter is ignored by the installer. > > [...] Applied, thanks! [1/1] ui: auto-installer: align network-tab with disks-tab commit: a52f563f73228d9ef7b2c2fe6bae3403c065bacf