From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com, "Max R. Carrara" <m.carrara@proxmox.com>
Subject: [pdm-devel] applied: [PATCH datacenter-manager v1] ui: remote wizard: fix "invalid uri character" when adding PBS remote
Date: Tue, 9 Dec 2025 17:43:54 +0100 [thread overview]
Message-ID: <176529862855.88133.273053272928153672.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251203191713.942001-1-m.carrara@proxmox.com>
On Wed, 03 Dec 2025 20:17:11 +0100, Max R. Carrara wrote:
> ... by normalizing the hostname in the form context directly when the
> user clicks on "Next" in the remote addition wizard.
>
> This is necessary because the wizard takes the values for submission
> directly from its form context.
>
> This is somewhat easy to run into, e.g. if one copy-pastes the URL of
> the PBS remote to add from another browser tab.
>
> [...]
Applied, thanks!
btw. might be also nice to extend normalize_hostname such that it also
removes hash anchor parts from the URL, as those are also often there if one
copies the full URL from the address bar of a PBS or PVE's web UI browser
tab.
FWIW, there is a web APIs to pare an URL [0], so it might be sensible to use
that API if the URL starts with `https?://` and get the host (hostname +
port) from there rather than continuing to heuristically strip away parts.
[0]: https://developer.mozilla.org/en-US/docs/Web/API/URL/parse_static
[1/1] ui: remote wizard: fix "invalid uri character" when adding PBS remote
commit: ca5a7957af2be8110d4a1052a60e10606f22e498
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-12-09 17:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 19:17 [pdm-devel] " Max R. Carrara
2025-12-09 16:43 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176529862855.88133.273053272928153672.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox