public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH proxmox-datacenter-manager] ui: firewall: disable collapse tree button if nothing is selected
@ 2025-12-03  7:36 Hannes Laimer
  2025-12-03 14:28 ` Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2025-12-03  7:36 UTC (permalink / raw)
  To: pdm-devel

The expanding button is in the header of the panel on the right,
without a selection there is no heading. So it wasn't possible to expand
the tree again after collapsing it.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 ui/src/remotes/firewall/tree.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ui/src/remotes/firewall/tree.rs b/ui/src/remotes/firewall/tree.rs
index ad538e0..8b1c883 100644
--- a/ui/src/remotes/firewall/tree.rs
+++ b/ui/src/remotes/firewall/tree.rs
@@ -290,7 +290,8 @@ impl FirewallTreeComponent {
             .with_child(
                 Button::new_icon("fa fa-angle-double-left")
                     .onclick(ctx.link().callback(|_| Msg::ToggleTreePanel))
-                    .aria_label(tr!("Hide tree panel")),
+                    .aria_label(tr!("Hide tree panel"))
+                    .disabled(self.selected_entry.is_none()),
             );
 
         let scope_toolbar = Toolbar::new()
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pdm-devel] [PATCH proxmox-datacenter-manager] ui: firewall: disable collapse tree button if nothing is selected
  2025-12-03  7:36 [pdm-devel] [PATCH proxmox-datacenter-manager] ui: firewall: disable collapse tree button if nothing is selected Hannes Laimer
@ 2025-12-03 14:28 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-12-03 14:28 UTC (permalink / raw)
  To: pdm-devel, Hannes Laimer

On Wed, 03 Dec 2025 08:36:43 +0100, Hannes Laimer wrote:
> The expanding button is in the header of the panel on the right,
> without a selection there is no heading. So it wasn't possible to expand
> the tree again after collapsing it.
> 
> 

Applied, thanks!

[1/1] ui: firewall: disable collapse tree button if nothing is selected
      commit: 36ed82144d736e1ce2785d6d478e6bc4b67a01f2


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-03 14:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-03  7:36 [pdm-devel] [PATCH proxmox-datacenter-manager] ui: firewall: disable collapse tree button if nothing is selected Hannes Laimer
2025-12-03 14:28 ` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal