From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com, Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager] api: fail with HTTP 403 Forbidden if user does have access to resource
Date: Wed, 5 Nov 2025 09:54:59 +0100 [thread overview]
Message-ID: <176233289803.867408.4717651978307282614.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251105081254.40625-2-l.wagner@proxmox.com>
On Wed, 05 Nov 2025 09:12:55 +0100, Lukas Wagner wrote:
> As discussed in another patch series [1], if a user does not have
> enough permissions to see a resource, we should fail with 403 Forbidden
> instead of 401 Unauthorized. The UI relies on returning the correct
> error codes, since a 401 will redirect the user to the login mask.
>
> [1] https://lore.proxmox.com/pdm-devel/DDJLG0Y8J5CP.1NMNIMD5ZEYZE@proxmox.com/
>
> [...]
Applied, slightly extended the commit message with a bit more reasoning,
thanks!
[1/1] api: fail with HTTP 403 Forbidden if user does have access to resource
commit: 5c2557f3f8a860aaaf919e1a6526c828635f2c11
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-11-05 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 8:12 Lukas Wagner
2025-11-05 8:54 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176233289803.867408.4717651978307282614.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox