[pdm-devel] partially-applied: [PATCH datacenter-manager v3 00/21] prepare ui for customizable views

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On Fri, 31 Oct 2025 13:43:43 +0100, Dominik Csapak wrote:
> This is the first step to have customizable views in the PDM ui.
> 
> A few open points:
> 
> * The `LoadResult` struct should probably live in either pwt or
>   yew-comp. I did not move it to pwt yet, but I'll do that for the next
>   version.

That would be IMO nice to do, but IMO was not a blocker for applying most of
this series now already, we can simply drop the local variant once it's
available through pwt.

> * Not super sure if this kind of structure is the one we desire.
>   The View is (for now) only a single layout (Row) that provides
>   the same behavior as the current layout. The whole logic is in the
>   View and every bit we want to add has to be handled there.

To be honest, I'm not 100% sure yet either, but this is simple enough that it
should be possible to still change this with a simple migration/mapping of the
view config without _that_ much work, and we probably will only get a real
feeling for what's a better approach, if any, when using and extending this
one, so IMO also not a blocker.

> 
> [...]

Applied all but the last one that would enable editing, which is confusing to
have as long as it's ephemeral. Thanks for grouping and ordering the patches
this way!

For UX it would be nice to get a "cancle edit" button when in edit mode, while
one can switch to another top-level navigation entry to implicitly cancle
editing, that's naturally rather subtle and not ideal UX.

Getting an undo/redo stack would be nice and shouldn't be all to hard, but as
that's not that important to have from the start, it's rather low on the
priority list.
Basic mechanism could be a vector (maybe VecDeque) with a maximum capacity,
new changes get pushed to the front, oldes ones get dropped if maximum capacity
is reached, undoing steps is simply going back in the queue, redo is going
forward again, undoing and then editing something drops every change that was
newer (as branched undo like emacs has would be rather overkill ^^).

[01/21] ui: dashboard: refactor guest panel creation to its own module
        commit: 9a1b28b9a974e125022f718608f0302d9f8ee435
[02/21] ui: dashboard: refactor creating the node panel into its own module
        commit: 11fcf7bc670b01be661483f698f16a46cca4e53d
[03/21] ui: dashboard: node panel: make remote type optional
        commit: 58dfd5b3eeef832ae2d87b49b7160e5f1b35daf0
[04/21] ui: dashboard: refactor remote panel creation into its own module
        commit: 726770c3b593e09aa054f09280ff98843fab2958
[05/21] ui: dashboard: remote panel: make wizard menu optional
        commit: a2c1477e3baabbbe72e204517aec7ec8d2684f71
[06/21] ui: dashboard: refactor sdn panel creation into its own module
        commit: 4486a7f961e0ca6a45474d75dbef77c475b3658a
[07/21] ui: dashboard: refactor task summary panel creation to its own module
        commit: 3f534f10ed3e5d02463881b397167ef8d77b435b
[08/21] ui: dashboard: task summary: disable virtual scrolling
        commit: 4b80cd0a08ad9bfcf9a007e1d04e0c3383d47fb5
[09/21] ui: dashboard: refactor subscription panel creation to its own module
        commit: 82ef7711a35be2034b17b945ad53b9de932effa0
[10/21] ui: dashboard: refactor top entities panel creation to its own module
        commit: ed2f836ea9ce9ec8d9473741efa68a712f324f8d
[11/21] ui: dashboard: refactor DashboardConfig editing/constants to their module
        commit: c726ddbef4f6f9018f55fae4d553468a5c019925
[12/21] ui: dashboard: factor out task parameter calculation
        commit: 2c4fb9dfda4751db91f4ae202c6659029a2a77c7
[13/21] ui: dashboard: pbs datastores panel: refactor creation into own module
        commit: 187e297a3994bb41ca60c1fa8d799fe88b1fc357
[14/21] ui: dashboard: remove unused remote list
        commit: 631e89d1aed6fef56340000104587b6aaa3dd0cb
[15/21] ui: dashboard: status row: make loading less jarring
        commit: 93b968d46e904852613e54458c5d50c4a5a61f7f
[16/21] ui: introduce `LoadResult` helper type
        commit: 7bf081261954a343e97404f535ff7636c7e9cfeb
[17/21] ui: dashboard: implement 'View'
        commit: 53fd1e9d0214ccfddcba0944e72a6e9cc7cfc0db
[18/21] ui: dashboard: use 'View' instead of the Dashboard
        commit: e2cd4a60d9fe3aaae460dc43a5683aafee5bdf42
[19/21] ui: dashboard: subscription info: move subscription loading to view
        commit: d6b752b89e287f328423d9deebb7387cc3b3b3f1
[20/21] ui: dashboard: use SharedState for create_*_panel
        commit: 0abf53c660e42d498e58f2d679f8bf2fc1cfc22f
[21/21] ui: dashboard: enable editing view
        NOTE: skipped.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel