From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pdm-devel] applied: [PATCH datacenter-manager 1/1] ui: remote wizard: validate remote ID
Date: Wed, 29 Oct 2025 15:09:28 +0100 [thread overview]
Message-ID: <176174696524.1776006.10760334798456181474.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251029134638.125532-2-f.ebner@proxmox.com>
On Wed, 29 Oct 2025 14:46:27 +0100, Fiona Ebner wrote:
> As reported in the community forum [0], the remote ID field in the
> remote wizard was not validated. When using an inavlid remote ID, only
> the backend would report an error upon submission. Add validation to
> the 'Remote ID' field to catch this early.
>
> [0]: https://forum.proxmox.com/threads/171742/post-808943
>
> [...]
Applied, thanks!
Tiny nit, but as I noticed it more than a few times now already:
Personally I'm not a big fan of cover-letters for simple single-patch
submissions, just adds noise. Basically I'd prefer:
- single commit -> single patch and no cover letter, it's basically just a
`git send-email -1` call anyway.
- multiple commits -> always a cover letter.
But if I'd have to chose between either always cover-letter or never I'd go for
always, so it's fine for me, just find it unnecessary and cost my slightly more
time to read a extra post to see if there is anything that special that
warrants a cover-letter for "just" a single patch.
[1/1] ui: remote wizard: validate remote ID
commit: 0e013085a1d6ed8b70cdb16f4d51af4f6b2f301f
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-10-29 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 13:46 [pdm-devel] [PATCH datacenter-manager 0/1] " Fiona Ebner
2025-10-29 13:46 ` [pdm-devel] [PATCH datacenter-manager 1/1] " Fiona Ebner
2025-10-29 14:09 ` Thomas Lamprecht [this message]
2025-10-29 14:20 ` [pdm-devel] applied: " Fiona Ebner
2025-10-29 14:46 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176174696524.1776006.10760334798456181474.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox