* [pdm-devel] [PATCH datacenter-manager 0/3] clippy fixes
@ 2025-10-16 11:35 Lukas Wagner
2025-10-16 11:35 ` [pdm-devel] [PATCH datacenter-manager 1/3] task cache: " Lukas Wagner
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Lukas Wagner @ 2025-10-16 11:35 UTC (permalink / raw)
To: pdm-devel
Lukas Wagner (3):
task cache: clippy fixes
api: resources: fix 'irrefutable let pattern' clippy warning
pbs-client: fix 'useless use of `format!`' clippy warning
server/src/api/resources.rs | 22 +++++++++++-----------
server/src/pbs_client.rs | 3 +--
server/src/remote_tasks/task_cache.rs | 10 +++-------
3 files changed, 15 insertions(+), 20 deletions(-)
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pdm-devel] [PATCH datacenter-manager 1/3] task cache: clippy fixes
2025-10-16 11:35 [pdm-devel] [PATCH datacenter-manager 0/3] clippy fixes Lukas Wagner
@ 2025-10-16 11:35 ` Lukas Wagner
2025-10-16 11:35 ` [pdm-devel] [PATCH datacenter-manager 2/3] api: resources: fix 'irrefutable let pattern' clippy warning Lukas Wagner
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Lukas Wagner @ 2025-10-16 11:35 UTC (permalink / raw)
To: pdm-devel
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
server/src/remote_tasks/task_cache.rs | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/server/src/remote_tasks/task_cache.rs b/server/src/remote_tasks/task_cache.rs
index aa038443..040266ad 100644
--- a/server/src/remote_tasks/task_cache.rs
+++ b/server/src/remote_tasks/task_cache.rs
@@ -827,13 +827,11 @@ impl TaskCache {
TaskArchiveIterator::new(Some(journal_file), archive_files, lock)
}
GetTasks::Active => {
- let mut archive_files = Vec::new();
-
- archive_files.push(ArchiveFile {
+ let archive_files = vec![ArchiveFile {
path: self.base_path.join(ACTIVE_FILENAME),
compressed: false,
starttime: 0,
- });
+ }];
TaskArchiveIterator::new(None, archive_files, lock)
}
@@ -957,9 +955,7 @@ impl<'a> TaskArchiveIterator<'a> {
inner: Box::new(inner),
_lock: lock,
}),
- Err(err) => {
- return Err(err.into());
- }
+ Err(err) => Err(err.into()),
}
} else {
Ok(Self {
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pdm-devel] [PATCH datacenter-manager 2/3] api: resources: fix 'irrefutable let pattern' clippy warning
2025-10-16 11:35 [pdm-devel] [PATCH datacenter-manager 0/3] clippy fixes Lukas Wagner
2025-10-16 11:35 ` [pdm-devel] [PATCH datacenter-manager 1/3] task cache: " Lukas Wagner
@ 2025-10-16 11:35 ` Lukas Wagner
2025-10-16 11:35 ` [pdm-devel] [PATCH datacenter-manager 3/3] pbs-client: fix 'useless use of `format!`' " Lukas Wagner
2025-10-16 22:48 ` [pdm-devel] applied: [PATCH datacenter-manager 0/3] clippy fixes Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Lukas Wagner @ 2025-10-16 11:35 UTC (permalink / raw)
To: pdm-devel
We could just drop the 'let PveSdnResouce::Zone(_) = &r' line completely
without changing behavior, but I've kept it in because it leads to a
compiler error once a new enum variant is introduced, forcing the
developer to handle the new variant there.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
server/src/api/resources.rs | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
index f4f56bcf..6bff7352 100644
--- a/server/src/api/resources.rs
+++ b/server/src/api/resources.rs
@@ -369,17 +369,17 @@ pub async fn get_status(
_ => counts.pve_nodes.unknown += 1,
},
Resource::PveSdn(r) => {
- if let PveSdnResource::Zone(_) = &r {
- match r.status() {
- SdnStatus::Available => {
- counts.sdn_zones.available += 1;
- }
- SdnStatus::Error => {
- counts.sdn_zones.error += 1;
- }
- SdnStatus::Unknown => {
- counts.sdn_zones.unknown += 1;
- }
+ let PveSdnResource::Zone(_) = &r;
+
+ match r.status() {
+ SdnStatus::Available => {
+ counts.sdn_zones.available += 1;
+ }
+ SdnStatus::Error => {
+ counts.sdn_zones.error += 1;
+ }
+ SdnStatus::Unknown => {
+ counts.sdn_zones.unknown += 1;
}
}
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pdm-devel] [PATCH datacenter-manager 3/3] pbs-client: fix 'useless use of `format!`' clippy warning
2025-10-16 11:35 [pdm-devel] [PATCH datacenter-manager 0/3] clippy fixes Lukas Wagner
2025-10-16 11:35 ` [pdm-devel] [PATCH datacenter-manager 1/3] task cache: " Lukas Wagner
2025-10-16 11:35 ` [pdm-devel] [PATCH datacenter-manager 2/3] api: resources: fix 'irrefutable let pattern' clippy warning Lukas Wagner
@ 2025-10-16 11:35 ` Lukas Wagner
2025-10-16 22:48 ` [pdm-devel] applied: [PATCH datacenter-manager 0/3] clippy fixes Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Lukas Wagner @ 2025-10-16 11:35 UTC (permalink / raw)
To: pdm-devel
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
server/src/pbs_client.rs | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/server/src/pbs_client.rs b/server/src/pbs_client.rs
index d8278c8a..433b5d4b 100644
--- a/server/src/pbs_client.rs
+++ b/server/src/pbs_client.rs
@@ -216,8 +216,7 @@ impl PbsClient {
propagate: true,
};
- let path = format!("/api2/extjs/access/acl");
- self.0.put(&path, &acl).await?;
+ self.0.put("/api2/extjs/access/acl", &acl).await?;
Ok(token)
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pdm-devel] applied: [PATCH datacenter-manager 0/3] clippy fixes
2025-10-16 11:35 [pdm-devel] [PATCH datacenter-manager 0/3] clippy fixes Lukas Wagner
` (2 preceding siblings ...)
2025-10-16 11:35 ` [pdm-devel] [PATCH datacenter-manager 3/3] pbs-client: fix 'useless use of `format!`' " Lukas Wagner
@ 2025-10-16 22:48 ` Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2025-10-16 22:48 UTC (permalink / raw)
To: pdm-devel, Lukas Wagner
On Thu, 16 Oct 2025 13:35:45 +0200, Lukas Wagner wrote:
> Lukas Wagner (3):
> task cache: clippy fixes
> api: resources: fix 'irrefutable let pattern' clippy warning
> pbs-client: fix 'useless use of `format!`' clippy warning
>
> server/src/api/resources.rs | 22 +++++++++++-----------
> server/src/pbs_client.rs | 3 +--
> server/src/remote_tasks/task_cache.rs | 10 +++-------
> 3 files changed, 15 insertions(+), 20 deletions(-)
>
> [...]
Applied, thanks!
[1/3] task cache: clippy fixes
commit: 8220ccd6217b7bdd8e338f0a510fd2ee47c2aa67
[2/3] api: resources: fix 'irrefutable let pattern' clippy warning
commit: fd5e5892a5ab992f9de6b9f63d2f41450ca62b23
[3/3] pbs-client: fix 'useless use of `format!`' clippy warning
commit: f83501bc047d6ba7c24cc1964f49642c55eeb6d5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-10-16 22:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-16 11:35 [pdm-devel] [PATCH datacenter-manager 0/3] clippy fixes Lukas Wagner
2025-10-16 11:35 ` [pdm-devel] [PATCH datacenter-manager 1/3] task cache: " Lukas Wagner
2025-10-16 11:35 ` [pdm-devel] [PATCH datacenter-manager 2/3] api: resources: fix 'irrefutable let pattern' clippy warning Lukas Wagner
2025-10-16 11:35 ` [pdm-devel] [PATCH datacenter-manager 3/3] pbs-client: fix 'useless use of `format!`' " Lukas Wagner
2025-10-16 22:48 ` [pdm-devel] applied: [PATCH datacenter-manager 0/3] clippy fixes Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox