public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH datacenter-manager 1/2] ui: remote wizard: fix width of settings panel
@ 2025-09-11  7:49 Dominik Csapak
  2025-09-11  7:49 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: remote wizard: add placeholder for token field Dominik Csapak
  2025-09-11 15:12 ` [pdm-devel] appliede: [PATCH datacenter-manager 1/2] ui: remote wizard: fix width of settings panel Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2025-09-11  7:49 UTC (permalink / raw)
  To: pdm-devel

the way we use a flex column layout and the properties of the input
panel do not work that well together for the width. by introducing
a row  that changes the flex direction changes the way the width works
and uses the full one here.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/remotes/wizard_page_info.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/src/remotes/wizard_page_info.rs b/ui/src/remotes/wizard_page_info.rs
index 88c6463..ff0e969 100644
--- a/ui/src/remotes/wizard_page_info.rs
+++ b/ui/src/remotes/wizard_page_info.rs
@@ -360,7 +360,7 @@ impl Component for PdmWizardPageInfo {
             );
         let content = Column::new()
             .class(FlexFit)
-            .with_child(input_panel)
+            .with_child(Row::new().with_child(input_panel))
             .with_child(
                 Row::new()
                     .padding(2)
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pdm-devel] [PATCH datacenter-manager 2/2] ui: remote wizard: add placeholder for token field
  2025-09-11  7:49 [pdm-devel] [PATCH datacenter-manager 1/2] ui: remote wizard: fix width of settings panel Dominik Csapak
@ 2025-09-11  7:49 ` Dominik Csapak
  2025-09-11 15:12 ` [pdm-devel] appliede: [PATCH datacenter-manager 1/2] ui: remote wizard: fix width of settings panel Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2025-09-11  7:49 UTC (permalink / raw)
  To: pdm-devel

so users know what the format should be (like we have it in e.g. the PBS
storage edit window in PVE)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/remotes/wizard_page_info.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/src/remotes/wizard_page_info.rs b/ui/src/remotes/wizard_page_info.rs
index ff0e969..2fd7fd3 100644
--- a/ui/src/remotes/wizard_page_info.rs
+++ b/ui/src/remotes/wizard_page_info.rs
@@ -333,6 +333,7 @@ impl Component for PdmWizardPageInfo {
                     .name("tokenid")
                     .disabled(self.user_mode)
                     .required(!self.user_mode)
+                    .placeholder(tr!("Example: user@realm!token"))
                     .submit(false),
             )
             .with_right_field(
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pdm-devel] appliede: [PATCH datacenter-manager 1/2] ui: remote wizard: fix width of settings panel
  2025-09-11  7:49 [pdm-devel] [PATCH datacenter-manager 1/2] ui: remote wizard: fix width of settings panel Dominik Csapak
  2025-09-11  7:49 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: remote wizard: add placeholder for token field Dominik Csapak
@ 2025-09-11 15:12 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-09-11 15:12 UTC (permalink / raw)
  To: pdm-devel, Dominik Csapak

On Thu, 11 Sep 2025 09:49:36 +0200, Dominik Csapak wrote:
> the way we use a flex column layout and the properties of the input
> panel do not work that well together for the width. by introducing
> a row  that changes the flex direction changes the way the width works
> and uses the full one here.
> 
> 

Applied, thanks!

[1/2] ui: remote wizard: fix width of settings panel
      commit: 74dd2ad797d201a6f4d0665dfa1cb36a6e52fe99
[2/2] ui: remote wizard: add placeholder for token field
      commit: 84667c0c97f34c9bfee60f84bc9b73dc3ef0d678


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-11 15:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-11  7:49 [pdm-devel] [PATCH datacenter-manager 1/2] ui: remote wizard: fix width of settings panel Dominik Csapak
2025-09-11  7:49 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: remote wizard: add placeholder for token field Dominik Csapak
2025-09-11 15:12 ` [pdm-devel] appliede: [PATCH datacenter-manager 1/2] ui: remote wizard: fix width of settings panel Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal