From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com, Lukas Wagner <l.wagner@proxmox.com>
Subject: [pdm-devel] applied: [PATCH proxmox-datacenter-manager] privileged api daemon: call fchownat with AT_SYMLINK_NOFOLLOW
Date: Fri, 8 Aug 2025 15:01:45 +0200 [thread overview]
Message-ID: <175465810336.1634502.13315257916647909911.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250807123712.218439-1-l.wagner@proxmox.com>
On Thu, 07 Aug 2025 14:37:12 +0200, Lukas Wagner wrote:
> AT_SYMLINK_FOLLOW makes the fchownat call fail with EINVAL, which
> prevents daemon startup alltogether. The only supported flag for
> fchownat is AT_SYMLINK_NOFOLLOW [1]. If one would actually would want to
> follow a symlink here one would have to pass no flag at all.
>
> The socket path which is fchownat'd here should not be a symlink at all,
> so the safer option should be to pass AT_SYMLINK_NOFOLLOW.
>
> [...]
Applied, thanks!
[1/1] privileged api daemon: call fchownat with AT_SYMLINK_NOFOLLOW
commit: cc9bc95e2da6bfbf3930627ebf6dc5427beea75b
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-08-08 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 12:37 [pdm-devel] " Lukas Wagner
2025-08-08 13:01 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175465810336.1634502.13315257916647909911.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox