Re: [pdm-devel] [PATCH proxmox/datacenter-manager v2 00/14] initial auto-installer integration

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox/datacenter-manager v2 00/14] initial auto-installer integration
Date: Fri, 5 Dec 2025 12:53:01 +0100	[thread overview]
Message-ID: <11b27b4a-7e1f-4af9-8384-12d54d72ef17@proxmox.com> (raw)
In-Reply-To: <20251205112528.373387-1-c.heiss@proxmox.com>

Am 05.12.25 um 12:25 schrieb Christoph Heiss:
> This series adds integration with our automated installer [0] for all our
> products. With this, Proxmox Datacenter Manager can be used for serving
> answer files via HTTP(S) in an automated fashion.
> 

Thanks for tackling this; IMO this work has the chance to become a very cool
feature!

> TOML API
> ========
> 
> The auto-installer (currently) only supports TOML as input format for
> the answer, so we need to hack around a bit to serve TOML in the API.
> This is done in patch #12, by implementing the api method
> directly. 
> 
> Serving TOML from an endpoint under /api2/json/ obviously is rather
> wrong, so I'm definitely open for suggestions. 
> We probably also don't want to implement `/api2/toml/` if I'd have to
> guess (or would that be possible selectively, i.e. just for this one
> endpoint?).

Making that selective should be possible in any case; another option
might be to add a "raw" one where the endpoints does the serialization
and returns a string directly, that would at least make it a bit more
flexible for the future; but not something we need to jump the gun now,
especially as this needs some care w.r.t. security – just giving the code
full control over content/type and content might be a bad idea; but the
content type could be part of the API schema definition.

> Adding JSON support to proxmox-fetch-answer is on my list, but this
> would still be needed if we want to keep compatibility with older ISOs.

FWIW; in general I'd be fine with this only working with newer ISOs, at
least as long as we do have published an ISO that has support for all our
projects; if we can support older ones without having to bend backwards
too much it would be naturally great too, and for that returning TOML
for json format can IMO be an OK stop-gap if the "raw" format is too
much scope creep. It would be nice if we could make that opt-in so that
newer ISOs can default to use JSON directly if they support it.

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel