public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	pdm-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: Re: applied: [PATCH datacenter-manager/proxmox v4 0/7] fix #6914: add option to remove already existing token
Date: Mon, 9 Mar 2026 10:44:16 +0100	[thread overview]
Message-ID: <0908109e-62d7-4979-9909-182bc16752cb@proxmox.com> (raw)
In-Reply-To: <177299416482.2028613.14201364803068895391.b4-ty@proxmox.com>

it seems the 2/6 commit is missing here, meaning the ui now uses an
option on delete that is not there in the api, was this
intentional? (i.e. is there something wrong with the patch from
your side?)

On 3/8/26 7:23 PM, Thomas Lamprecht wrote:
> On Wed, 18 Feb 2026 17:41:28 +0100, Shan Shaji wrote:
>> If a user removed a remote without deleting its associated token,
>> PDM would not allow re-adding the same remote unless the token
>> was changed. To fix this, support for optionally deleting the token
>> on the remote has been added.
>>
>> new changes:
>> - use ConfirmDialog widget for creating the confirmation dialog.
>> - add token deletion as opt-out feature.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/6] server: pbs-client: add method to delete token from remote
>        commit: cef803fde6069c32cb79182336a7f8c62f31342b
> [1/1] pve-api-types: generate missing `delete_token` method
>        (no commit info)
> [3/6] pdm-client: accept `delete-token` argument for deleting api token
>        commit: fa87d7c7b40e89cb528c78ecac217cd31d713061
> [4/6] fix #6914: cli-client: add option to delete token from remote
>        commit: 8249b9a40b0b47f600edc8f552fedd19ac12b4cf
> [5/6] fix #6914: ui: add remove remote dialog with optional token deletion
>        commit: 4ecebbcbdc6c232c8dcc5d45e83bd39d81480991
> [6/6] fix #6914: cli-admin: add option to delete token from remote
>        commit: 461f3331545c4f5c4d21a05f64c8f374fa06ad5e
> 
> 
> 
> 





  reply	other threads:[~2026-03-09  9:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 16:41 Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 1/6] server: pbs-client: add method to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 2/6] fix #6914: api: add support " Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 3/6] pdm-client: accept `delete-token` argument for deleting api token Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 4/6] fix #6914: cli-client: add option to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 5/6] fix #6914: ui: add remove remote dialog with optional token deletion Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 6/6] fix #6914: cli-admin: add option to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH proxmox v4 1/1] pve-api-types: generate missing `delete_token` method Shan Shaji
2026-03-09 20:52   ` applied: " Thomas Lamprecht
2026-02-24 13:06 ` [PATCH datacenter-manager/proxmox v4 0/7] fix #6914: add option to remove already existing token Lukas Wagner
2026-03-08 18:23 ` applied: " Thomas Lamprecht
2026-03-09  9:44   ` Dominik Csapak [this message]
2026-03-09 22:05     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0908109e-62d7-4979-9909-182bc16752cb@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=s.shaji@proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal