Re: [pdm-devel] [PATCH datacenter-manager v4 0/8] add task summary panels in dashboard

[Stefan Hanreich <s.hanreich@proxmox.com>]

Looked at the changes - series LGTM from my POV now.

I also gave this another quick spin on my PDM instance:

Ran some tasks and re-checked the Dashboard overview if the information
has been correctly updated / applied. Did cover each remote / task type
/ result type (ok, warning, ..) once with the tasks I ran.

Played with the different duration settings as well.

Consider this:

Reviewed-by: Stefan Hanreich <s.hanreich@proxmox.com>
Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>


On 8/26/25 12:22 PM, Dominik Csapak wrote:
> This adds new panels to the dashboard for showing summaries of the tasks:
> * one by category
> * one by remote
> 
> similar to what we have in PBS.
> 
> I did not implement a cache for the data on the backend, but this can be
> done as a follow up and should not impact the UI code at all.
> 
> changes from v3:
> * instead of having freestanding helper functions, introduce a struct
>   with methods that we can pass around, this makes it easier to sort,
>   etc. also with this we can get rid of another helper type in the
>   tasks ui
> * changed to a btreemap from a hashmap to keep the sorting we get from
>   the TaskWorkerType
> * deduplicated the since/hour calculation in the dashboard
> 
> 
> changes from v2:
> * rebase on current master (incl task caching changes from lukas)
> * new patch (8/8) that includes configuring the time frame to check the
>   tasks for
> 
> Changes from v1:
> * incorporated most suggestions from Thomas
> * split up patches a bit
> * added new server api call
> * (the UI code is very different to accomodate the necessary changes)
> 
> 
> 
> Dominik Csapak (8):
>   server: task cache: treat a limit of 0 as unbounded
>   server: api: remote tasks: add 'remote' filter option
>   server: api: add remote-tasks statistics
>   ui: refactor remote upid formatter
>   ui: tasks: add helper to summarize task categories
>   ui: add dialog to show filtered tasks
>   ui: dashboard: add task summaries
>   ui: dashboard: make task summary time range configurable
> 
>  lib/pdm-api-types/src/lib.rs       |  46 +++++
>  server/src/api/remote_tasks.rs     |  88 ++++++++-
>  server/src/remote_tasks/mod.rs     |  17 +-
>  ui/src/dashboard/filtered_tasks.rs | 291 ++++++++++++++++++++++++++++
>  ui/src/dashboard/mod.rs            | 128 +++++++++++-
>  ui/src/dashboard/tasks.rs          | 301 +++++++++++++++++++++++++++++
>  ui/src/remotes/tasks.rs            |  19 +-
>  ui/src/tasks.rs                    | 103 +++++++++-
>  ui/src/top_nav_bar.rs              |  18 +-
>  9 files changed, 966 insertions(+), 45 deletions(-)
>  create mode 100644 ui/src/dashboard/filtered_tasks.rs
>  create mode 100644 ui/src/dashboard/tasks.rs
> 



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel