public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] cargo: add pbs-api-types override and reorder overrides
@ 2025-02-20 15:31 Gabriel Goller
  2025-02-20 15:35 ` Wolfgang Bumiller
  0 siblings, 1 reply; 3+ messages in thread
From: Gabriel Goller @ 2025-02-20 15:31 UTC (permalink / raw)
  To: pbs-devel

Add the new pbs-api-types crate to the cargo override section. Reorder
the overrides to be alphabetic.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 Cargo.toml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index 062de7cfb989..427e3e2d57e8 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -253,7 +253,7 @@ proxmox-rrd-api-types.workspace = true
 # Local path overrides
 # NOTE: You must run `cargo update` after changing this for it to take effect!
 [patch.crates-io]
-
+#proxmox-acme = { path = "../proxmox/proxmox-acme" }
 #proxmox-apt = { path = "../proxmox/proxmox-apt" }
 #proxmox-apt-api-types = { path = "../proxmox/proxmox-apt-api-types" }
 #proxmox-async = { path = "../proxmox/proxmox-async" }
@@ -289,8 +289,8 @@ proxmox-rrd-api-types.workspace = true
 #proxmox-uuid = { path = "../proxmox/proxmox-uuid" }
 #proxmox-worker-task = { path = "../proxmox/proxmox-worker-task" }
 
-#proxmox-acme = { path = "../proxmox/proxmox-acme" }
 #pathpatterns = {path = "../pathpatterns" }
+#pbs-api-types = { path = "../proxmox/pbs-api-types" }
 #pxar = { path = "../pxar" }
 
 [features]
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pbs-devel] [PATCH proxmox-backup] cargo: add pbs-api-types override and reorder overrides
  2025-02-20 15:31 [pbs-devel] [PATCH proxmox-backup] cargo: add pbs-api-types override and reorder overrides Gabriel Goller
@ 2025-02-20 15:35 ` Wolfgang Bumiller
  2025-02-20 15:52   ` Gabriel Goller
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Bumiller @ 2025-02-20 15:35 UTC (permalink / raw)
  To: Gabriel Goller; +Cc: pbs-devel

On Thu, Feb 20, 2025 at 04:31:36PM +0100, Gabriel Goller wrote:
> Add the new pbs-api-types crate to the cargo override section. Reorder
> the overrides to be alphabetic.
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  Cargo.toml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Cargo.toml b/Cargo.toml
> index 062de7cfb989..427e3e2d57e8 100644
> --- a/Cargo.toml
> +++ b/Cargo.toml
> @@ -253,7 +253,7 @@ proxmox-rrd-api-types.workspace = true
>  # Local path overrides
>  # NOTE: You must run `cargo update` after changing this for it to take effect!
>  [patch.crates-io]
> -
> +#proxmox-acme = { path = "../proxmox/proxmox-acme" }
>  #proxmox-apt = { path = "../proxmox/proxmox-apt" }
>  #proxmox-apt-api-types = { path = "../proxmox/proxmox-apt-api-types" }
>  #proxmox-async = { path = "../proxmox/proxmox-async" }
> @@ -289,8 +289,8 @@ proxmox-rrd-api-types.workspace = true
>  #proxmox-uuid = { path = "../proxmox/proxmox-uuid" }
>  #proxmox-worker-task = { path = "../proxmox/proxmox-worker-task" }
>  
> -#proxmox-acme = { path = "../proxmox/proxmox-acme" }
>  #pathpatterns = {path = "../pathpatterns" }
> +#pbs-api-types = { path = "../proxmox/pbs-api-types" }

While the name looks different, given that overrides need to be enabled
as complete workspaces I'd argue this line should be in the proxmox.git
block above.

>  #pxar = { path = "../pxar" }
>  
>  [features]
> -- 
> 2.39.5


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pbs-devel] [PATCH proxmox-backup] cargo: add pbs-api-types override and reorder overrides
  2025-02-20 15:35 ` Wolfgang Bumiller
@ 2025-02-20 15:52   ` Gabriel Goller
  0 siblings, 0 replies; 3+ messages in thread
From: Gabriel Goller @ 2025-02-20 15:52 UTC (permalink / raw)
  To: Wolfgang Bumiller; +Cc: pbs-devel

On 20.02.2025 16:35, Wolfgang Bumiller wrote:
>On Thu, Feb 20, 2025 at 04:31:36PM +0100, Gabriel Goller wrote:
>> Add the new pbs-api-types crate to the cargo override section. Reorder
>> the overrides to be alphabetic.
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>>  Cargo.toml | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Cargo.toml b/Cargo.toml
>> index 062de7cfb989..427e3e2d57e8 100644
>> --- a/Cargo.toml
>> +++ b/Cargo.toml
>> @@ -253,7 +253,7 @@ proxmox-rrd-api-types.workspace = true
>>  # Local path overrides
>>  # NOTE: You must run `cargo update` after changing this for it to take effect!
>>  [patch.crates-io]
>> -
>> +#proxmox-acme = { path = "../proxmox/proxmox-acme" }
>>  #proxmox-apt = { path = "../proxmox/proxmox-apt" }
>>  #proxmox-apt-api-types = { path = "../proxmox/proxmox-apt-api-types" }
>>  #proxmox-async = { path = "../proxmox/proxmox-async" }
>> @@ -289,8 +289,8 @@ proxmox-rrd-api-types.workspace = true
>>  #proxmox-uuid = { path = "../proxmox/proxmox-uuid" }
>>  #proxmox-worker-task = { path = "../proxmox/proxmox-worker-task" }
>>
>> -#proxmox-acme = { path = "../proxmox/proxmox-acme" }
>>  #pathpatterns = {path = "../pathpatterns" }
>> +#pbs-api-types = { path = "../proxmox/pbs-api-types" }
>
>While the name looks different, given that overrides need to be enabled
>as complete workspaces I'd argue this line should be in the proxmox.git
>block above.

Ok, submitted a v2!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-20 15:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-20 15:31 [pbs-devel] [PATCH proxmox-backup] cargo: add pbs-api-types override and reorder overrides Gabriel Goller
2025-02-20 15:35 ` Wolfgang Bumiller
2025-02-20 15:52   ` Gabriel Goller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal