From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] applied: [PATCH v2] add tracing init_cli_logger and deprecate old one
Date: Tue, 3 Sep 2024 14:21:59 +0200 [thread overview]
Message-ID: <yi7yp6fg36awvwy4gykx6xv3bvyl54ei6fgruh42bw7alyr3k6@fx54tlham57a> (raw)
In-Reply-To: <20240903121051.cgl67w2ucciqpgig@luna.proxmox.com>
On Tue, Sep 03, 2024 at 02:10:51PM GMT, Gabriel Goller wrote:
> Christian Ebner and I just noticed that previously all the output was on
> stderr, because the `env_logger` prints everything to stderr
> per-default [0]. This means that all the console output from
> proxmox-backup-client, -manager, -debug, -file-restore, pxar, etc. is
> now on stdout.
>
> There is one test failing in pxar-bin, but I have a patch ready for that
> already.
>
> But will this cause more problems down the road? Do we rely somwhere on the
> stderr output? Should I change the tracing output to stderr as well?
>
> [0]: https://docs.rs/env_logger/latest/env_logger/
Yeah having logs go to stderr would make sense.
CLI tool output that is meant to be "useful" for *tooling* should be
printed with `println!()` after all, not "logged".
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-09-03 12:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 13:40 [pbs-devel] " Gabriel Goller
2024-08-29 13:40 ` [pbs-devel] [PATCH proxmox-backup v2 1/2] move client binaries to tracing Gabriel Goller
2024-08-29 13:41 ` Gabriel Goller
2024-08-30 11:58 ` [pbs-devel] applied: [PATCH v2] add tracing init_cli_logger and deprecate old one Wolfgang Bumiller
2024-09-03 12:10 ` Gabriel Goller
2024-09-03 12:21 ` Wolfgang Bumiller [this message]
2024-09-03 12:27 ` Gabriel Goller
2024-09-03 12:38 ` Wolfgang Bumiller
2024-09-03 14:40 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yi7yp6fg36awvwy4gykx6xv3bvyl54ei6fgruh42bw7alyr3k6@fx54tlham57a \
--to=w.bumiller@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox