From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup v4 6/7] ui: show consent banner before login
Date: Tue, 26 Nov 2024 11:01:52 +0100 [thread overview]
Message-ID: <xa7m2c2h472nl7rhloiqnhd3y3lo7vw7xzanwccomh4vflwb7e@dpbeewqlvfli> (raw)
In-Reply-To: <051476db-154f-49be-ae4b-fd764c22de5e@proxmox.com>
On 25.11.2024 19:12, Thomas Lamprecht wrote:
>Am 13.09.24 um 15:10 schrieb Gabriel Goller:
>> Before showing the LoginView, check if we got a non-empty consent text
>> from the template. If there is a non-empty text, display it in a modal.
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>> www/LoginView.js | 12 ++++++++++++
>> www/config/NodeOptionView.js | 6 ++++++
>> www/index.hbs | 1 +
>> 3 files changed, 19 insertions(+)
>>
>>
>
>applied, with the indentation mess in the init function a bit improved, thanks!
Thanks!
>btw. onnlineHelp link would be great, IMO it's a bit of a confusing setting as
>is.
Will send two follow-up patches with this one and the small nit on the first
commit!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-26 10:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:10 [pbs-devel] [PATCH proxmox{, -backup}/widget-toolkit v4 0/7] fix #5463: add optional " Gabriel Goller
2024-09-13 13:10 ` [pbs-devel] [PATCH widget-toolkit v4 1/7] utils: add base64 conversion helper Gabriel Goller
2024-09-17 7:37 ` Thomas Lamprecht
2024-11-26 10:31 ` Gabriel Goller
2024-11-26 11:06 ` Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH widget-toolkit v4 2/7] window: add consent modal Gabriel Goller
2024-11-25 17:26 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH widget-toolkit v4 3/7] form: add support for multiline textarea Gabriel Goller
2024-11-25 17:26 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox v4 4/7] rest-server: add custom handlebars escape fn Gabriel Goller
2024-11-25 15:39 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox-backup v4 5/7] api: add consent api handler and config option Gabriel Goller
2024-11-25 18:11 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox-backup v4 6/7] ui: show consent banner before login Gabriel Goller
2024-11-25 18:12 ` [pbs-devel] applied: " Thomas Lamprecht
2024-11-26 10:01 ` Gabriel Goller [this message]
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox-backup v4 7/7] docs: add section about consent banner Gabriel Goller
2024-11-25 18:13 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa7m2c2h472nl7rhloiqnhd3y3lo7vw7xzanwccomh4vflwb7e@dpbeewqlvfli \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox