From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox 1/2] proxmox-log: added tracing infra
Date: Fri, 1 Dec 2023 12:13:45 +0100 [thread overview]
Message-ID: <w6qlkeo77xiqsorygj5zudqefwsbjajwjjoza3kuezactrtzuz@kd6hkprd4xjj> (raw)
In-Reply-To: <48fb398e-d7d4-4e7b-a313-057953b82aca@proxmox.com>
On Fri, Dec 01, 2023 at 10:56:47AM +0100, Lukas Wagner wrote:
> Hello,
> I'm currently evaluating how this crate could be used from the
> proxmox-perl-rs bindings.
>
> The status quo there is that we initialize an envlogger, but that leads to
> the problem that logs are only visible for tasks, since envlogger does log
> to stdout (or was it stderr?).
> To differentiate between 'daemon context' and 'fork worker context' we
> obviously cannot rely on a tokio task-local var there.
I'm not convinced we'll be able to keep tokio out of there for long -
if only to block_on some futures via a current_thread runtime.
> Maybe it would make sense to have an alternative mode (gated via
> feature-flags) with a static flag, which is then set in
> RestEnvironment::fork_worker via a setter?
Sure. This can of course also be a follow up (I haven't looked over
this version yet).
> The dependency on tokio should then also be feature-gated, since we don't
> want to have to pull in tokio as a dep for proxmox-perl-rs yet.
👍
next prev parent reply other threads:[~2023-12-01 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 11:28 [pbs-devel] [PATCH proxmox-backup 0/2] proxmox-log introduction Gabriel Goller
2023-11-03 11:28 ` [pbs-devel] [PATCH proxmox 1/2] proxmox-log: added tracing infra Gabriel Goller
2023-12-01 9:56 ` Lukas Wagner
2023-12-01 11:13 ` Wolfgang Bumiller [this message]
2023-12-01 14:48 ` Lukas Wagner
2023-11-03 11:28 ` [pbs-devel] [PATCH proxmox-backup 2/2] log: removed task_log! macro and moved to tracing Gabriel Goller
2024-01-22 13:30 ` Lukas Wagner
2023-12-15 13:56 ` [pbs-devel] [PATCH proxmox-backup 0/2] proxmox-log introduction Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w6qlkeo77xiqsorygj5zudqefwsbjajwjjoza3kuezactrtzuz@kd6hkprd4xjj \
--to=w.bumiller@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox