public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox] router: sort cli properties in usage output
Date: Fri, 30 Aug 2024 13:33:00 +0200	[thread overview]
Message-ID: <vhvkc26olqlgpmdoei4hizh4tyltithfspa5fki7mvb2mmth3g@vsrxsvdx7gfn> (raw)
In-Reply-To: <20240809082525.864042-1-d.csapak@proxmox.com>

On Fri, Aug 09, 2024 at 10:25:25AM GMT, Dominik Csapak wrote:
> If we don't do this, then properties from a serde flattened struct will
> be positioned at the end of the list, rather than properly sorted with
> the other properties.
> 
> Since the tests also feature non-sorted properties, we have to adapt
> them too.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> i wanted to add tests for the serde flattened structs, but the test
> don't use the api macro, nor serde, so i was not sure how i could
> replicate that. If somebody has an idea for that, please tell, then
> I'll send a v2 or follow up

Those are just `AllOfSchemas` , you'd just have to make 2
`ObjectSchemas` and put them into an `AllOfSchema`.

I do wonder, though, whether we want some way to declare "groups" for
the documentation.
Using a flattened structs might sometimes work, but probably not all the
time. With this applied, flattened structs won't make a difference. But
given that the visible portion of the struct in code doesn't represent
the way it would be grouped anyway, we'd need a separate solution to
declare groups anyway.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      reply	other threads:[~2024-08-30 11:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09  8:25 [pbs-devel] " Dominik Csapak
2024-08-30 11:33 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vhvkc26olqlgpmdoei4hizh4tyltithfspa5fki7mvb2mmth3g@vsrxsvdx7gfn \
    --to=w.bumiller@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal