public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH v3 proxmox 1/6] worker task: include anyhow error context in state error message
Date: Thu, 20 Mar 2025 14:47:22 +0100	[thread overview]
Message-ID: <tnmgylnkhz42sqboxy2rdliaymoc2qjzdqddizaahcrxyvb5ed@ewgor6ipvu45> (raw)
In-Reply-To: <20250320123010.250234-2-c.ebner@proxmox.com>

(this is a duplicate - it's applied now)

On Thu, Mar 20, 2025 at 01:30:05PM +0100, Christian Ebner wrote:
> Currently the anyhow error context of a given error is not included
> in the error message, as `to_string` does use the default formatting
> [0].
> 
> Include the error context, formatting it as single line as the
> message is also shown to the users in e.g. the Proxmox Backup Severs
> task state in the UI.
> 
> [0] https://docs.rs/anyhow/latest/anyhow/struct.Error.html#display-representations
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 1:
> - not present in previous version
> 
>  proxmox-rest-server/src/worker_task.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/proxmox-rest-server/src/worker_task.rs b/proxmox-rest-server/src/worker_task.rs
> index 2968a68c..a3a65add 100644
> --- a/proxmox-rest-server/src/worker_task.rs
> +++ b/proxmox-rest-server/src/worker_task.rs
> @@ -1003,7 +1003,7 @@ impl WorkerTask {
>  
>          if let Err(err) = result {
>              TaskState::Error {
> -                message: err.to_string(),
> +                message: format!("{err:#}"),
>                  endtime,
>              }
>          } else if warn_count > 0 {
> -- 
> 2.39.5


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-03-20 13:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 12:30 [pbs-devel] [PATCH v3 proxmox proxmox-backup 0/6] GC: avoid multiple atime updates Christian Ebner
2025-03-20 12:30 ` [pbs-devel] [PATCH v3 proxmox 1/6] worker task: include anyhow error context in state error message Christian Ebner
2025-03-20 13:47   ` Wolfgang Bumiller [this message]
2025-03-20 12:30 ` [pbs-devel] [PATCH v3 proxmox-backup 2/6] tools: lru cache: tell if node was already present or newly inserted Christian Ebner
2025-03-20 12:30 ` [pbs-devel] [PATCH v3 proxmox-backup 3/6] garbage collection: format error including anyhow error context Christian Ebner
2025-03-20 12:30 ` [pbs-devel] [PATCH v3 proxmox-backup 4/6] datastore: add helper method to open index reader from path Christian Ebner
2025-03-20 14:22   ` Wolfgang Bumiller
2025-03-20 14:40     ` Christian Ebner
2025-03-20 12:30 ` [pbs-devel] [PATCH v3 proxmox-backup 5/6] garbage collection: generate image list via datastore iterators Christian Ebner
2025-03-20 12:30 ` [pbs-devel] [PATCH v3 proxmox-backup 6/6] fix #5331: garbage collection: avoid multiple chunk atime updates Christian Ebner
2025-03-21  9:32 ` [pbs-devel] [PATCH v3 proxmox proxmox-backup 0/6] GC: avoid multiple " Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tnmgylnkhz42sqboxy2rdliaymoc2qjzdqddizaahcrxyvb5ed@ewgor6ipvu45 \
    --to=w.bumiller@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal