From: Gabriel Goller <g.goller@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] improve push sync job log messages
Date: Thu, 21 Nov 2024 18:04:03 +0100 [thread overview]
Message-ID: <tjvd5is7uz5ob46sxmmjohtawsddzundpoqoj563mvjztvasmf@u3rms5dzeqht> (raw)
In-Reply-To: <f2fe996a-c915-49ba-9f15-661a4283c337@proxmox.com>
On 21.11.2024 17:26, Christian Ebner wrote:
>On 11/21/24 17:06, Gabriel Goller wrote:
>>I think I'd be nice if we use `.context()` instead of `format_err` and
>>debug print ("{err:?}") instead of default ("{}") here. As these
>>messages are all errors they shouldn't appear too often in the log and
>>if an error happens, you get much more information.
>>
>>What do you think?
>
>Hmm, can check that out, but wouldn't that disrupt the single line
>character of the log entries, prefixed by the time stamp?
We could use "{err:#}", which will print everything in one line?
Although on the other hand, I'd understand if you want to have strict
control over what is displayed to the users, so no hard feelings on
this one.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-21 17:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 15:43 Christian Ebner
2024-11-21 15:43 ` [pbs-devel] [PATCH proxmox-backup 1/4] server: push: fix needless borrow clippy warning Christian Ebner
2024-11-21 15:43 ` [pbs-devel] [PATCH proxmox-backup 2/4] server: push: consistently use remote over target for error messages Christian Ebner
2024-11-21 15:43 ` [pbs-devel] [PATCH proxmox-backup 3/4] server: push: add error context to all target api calls Christian Ebner
2024-11-22 9:01 ` Fabian Grünbichler
2024-11-22 10:11 ` Christian Ebner
2024-11-21 15:43 ` [pbs-devel] [PATCH proxmox-backup 4/4] server: push: various smaller improvements to error messages Christian Ebner
2024-11-21 16:06 ` [pbs-devel] [PATCH proxmox-backup 0/4] improve push sync job log messages Gabriel Goller
2024-11-21 16:26 ` Christian Ebner
2024-11-21 17:04 ` Gabriel Goller [this message]
2024-11-21 19:32 ` Fabian Grünbichler
2024-11-22 8:41 ` Christian Ebner
2024-11-22 12:28 ` Christian Ebner
2024-11-22 9:04 ` [pbs-devel] partially-applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tjvd5is7uz5ob46sxmmjohtawsddzundpoqoj563mvjztvasmf@u3rms5dzeqht \
--to=g.goller@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox