public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox 1/3] time: Add traits to DateTimeValue and TimeSpec
Date: Wed, 13 Aug 2025 13:30:03 +0200	[thread overview]
Message-ID: <s8osehvzcg4.fsf@proxmox.com> (raw)
In-Reply-To: <9494a5a1-7c49-4f95-8b93-90d6897af421@proxmox.com> (Dominik Csapak's message of "Wed, 13 Aug 2025 13:27:33 +0200")

Dominik Csapak <d.csapak@proxmox.com> writes:

> On 8/13/25 13:26, Maximiliano Sandoval wrote:
>> Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
>> 
>>> which are useful for tests.
>>>
>>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>>> ---
>>>   proxmox-time/src/calendar_event.rs  | 1 +
>>>   proxmox-time/src/date_time_value.rs | 2 +-
>>>   2 files changed, 2 insertions(+), 1 deletion(-)
>> In a support case we found a system with 40:00 as a schedule in a backup
>> job. It is possible to entire this calendar event on the web UI.
>> After this series the web UI won't allow it anymore with an error:
>> ```
>> Parameter verification failed. (400)
>> schedule: invalid format - invalid calendar event '40:00' - unable to parse
>> calendar event at ':00' - Nom(Eof)
>> ```
>> 
>
> but that is a valid calendar spec? it just means something different than what
> the user expected ? (every hour at minute 40)

At least systemd-analyze does not like it:

```
systemd-analyze calendar 40:00
Failed to parse calendar specification '40:00': Invalid argument
```

I would hope that 20:00 is no different than 40:00 (e.g. the first
component refers to hours). Is the "calendar spec" defined somewhere?

-- 
Maximiliano


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-08-13 11:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 11:03 Maximiliano Sandoval
2025-08-13 11:03 ` [pbs-devel] [PATCH proxmox 2/3] time: Split parse_time_spec parser into two Maximiliano Sandoval
2025-08-13 11:03 ` [pbs-devel] [PATCH proxmox 3/3] time: Add more calendat event tests Maximiliano Sandoval
2025-08-13 11:22 ` [pbs-devel] [PATCH proxmox 1/3] time: Add traits to DateTimeValue and TimeSpec Maximiliano Sandoval
2025-08-13 11:26 ` Maximiliano Sandoval
2025-08-13 11:27   ` Dominik Csapak
2025-08-13 11:30     ` Maximiliano Sandoval [this message]
2025-08-13 11:32       ` Dominik Csapak
2025-08-13 12:31   ` Fiona Ebner
2025-08-13 12:38     ` Maximiliano Sandoval
2025-08-13 12:41       ` Fiona Ebner
2025-08-13 13:07 ` [pbs-devel] superseded: " Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8osehvzcg4.fsf@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal