public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH offline-mirror] mirror: Use PathBuf instead of strings for paths
Date: Mon, 27 Nov 2023 09:37:20 +0100	[thread overview]
Message-ID: <s8oh6l7mw0l.fsf@proxmox.com> (raw)
In-Reply-To: <4c32001f-640b-4118-9d50-52a2305e1408@proxmox.com>

Yes, it ends up being mostly cosmetic.

Thomas Lamprecht <t.lamprecht@proxmox.com> writes:

> Am 21/11/2023 um 14:50 schrieb Maximiliano Sandoval R:
>> Joining the strings might results in a double `//` in a path. This was
>> experienced in a ticket at our customer support in the following error:
>>
>>     Error: unable to read
>>     "/var/lib/proxmox-offline-mirror/mirrors//.pool/sha256/<SOME_HASH>"
>>     - Input/output error (os error 5) after downloading ±60GB of data.
>
>
> I mean, that's an example where one can view this slightly cosmetic issue,
> not really the cause for the actual error, like your message tends to
> suggest, I hope?!


--
Maximiliano




  reply	other threads:[~2023-11-27  8:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21 13:50 Maximiliano Sandoval R
2023-11-25 16:20 ` Thomas Lamprecht
2023-11-27  8:37   ` Maximiliano Sandoval [this message]
2024-01-09  8:28 ` [pbs-devel] applied: " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8oh6l7mw0l.fsf@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal