Re: [pbs-devel] [PATCH proxmox 1/3] time: Add traits to DateTimeValue and TimeSpec

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Fiona Ebner <f.ebner@proxmox.com> writes:

> Am 13.08.25 um 1:26 PM schrieb Maximiliano Sandoval:
>> 
>> Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
>> 
>>> which are useful for tests.
>>>
>>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>>> ---
>>>  proxmox-time/src/calendar_event.rs  | 1 +
>>>  proxmox-time/src/date_time_value.rs | 2 +-
>>>  2 files changed, 2 insertions(+), 1 deletion(-)
>> 
>> In a support case we found a system with 40:00 as a schedule in a backup
>> job. It is possible to entire this calendar event on the web UI.
>> 
>> After this series the web UI won't allow it anymore with an error:
>> 
>> ```
>> Parameter verification failed. (400)
>> 
>> schedule: invalid format - invalid calendar event '40:00' - unable to parse calendar event at ':00' - Nom(Eof) 
>> ```
>> 
>
> Note that we have the same behavior in Proxmox VE:
> https://bugzilla.proxmox.com/show_bug.cgi?id=6161
>
> If it is changed, it should be made consistent between products.
> Unfortunately, this one got missed before the major releases, as one
> could consider this a breaking change.

The Proxmox VE web UI uses this crate so it would be consistent, I
tested the change against it.

I can do a v2 referencing the bugzilla entry, and add a test for "24:00"
which returns an error with this patch (as it should).

-- 
Maximiliano


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel