From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox v2 1/2] sys: Use safe wrapper for libc::isatty
Date: Mon, 27 Nov 2023 11:09:33 +0100 [thread overview]
Message-ID: <s8ocyvvmroy.fsf@proxmox.com> (raw)
In-Reply-To: <1701076239.pskhtz7vig.astroid@yuna.none>
Fabian Grünbichler <f.gruenbichler@proxmox.com> writes:
> do we still need these two? I assume everything calling this would then
> do something with stdin/stdout anyway, and could just as well call
> is_terminal() on them? might be a candidate for deprecation, since the
> original reason for their existence (pulling out the `unsafe` part into
> a helper) is gone..
I tried sending patches for all possible users of those two functions,
but I might have missed some. I would mark them as deprecated once the
patches are applied.
--
Maximiliano
next prev parent reply other threads:[~2023-11-27 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 8:16 Maximiliano Sandoval R
2023-11-20 8:16 ` [pbs-devel] [PATCH proxmox v2 2/2] router: " Maximiliano Sandoval R
2023-11-27 9:15 ` [pbs-devel] [PATCH proxmox v2 1/2] sys: " Fabian Grünbichler
2023-11-27 10:09 ` Maximiliano Sandoval [this message]
2023-11-27 13:15 ` Wolfgang Bumiller
2024-02-16 14:59 Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8ocyvvmroy.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox