From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied-series: [PATCH proxmox 01/10] clippy: remove needless borrow
Date: Fri, 09 Aug 2024 13:11:24 +0200 [thread overview]
Message-ID: <s8o8qx6ar37.fsf@proxmox.com> (raw)
In-Reply-To: <71a9f6ff-44b0-4ead-bd66-1344274e7f7a@proxmox.com> (Thomas Lamprecht's message of "Wed, 7 Aug 2024 20:59:37 +0200")
Thomas Lamprecht <t.lamprecht@proxmox.com> writes:
> On 07/08/2024 09:43, Maximiliano Sandoval wrote:
>> Fixes the clippy warning:
>>
>> warning: this expression borrows a value the compiler would automatically borrow
>> --> proxmox-apt/src/repositories/file/sources_parser.rs:111:40
>> |
>> 111 | ... types.push((&package_type[..]).parse()?);
>> | ^^^^^^^^^^^^^^^^^^^ help: change this to: `package_type[..]`
>> |
>> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
>> = note: `#[warn(clippy::needless_borrow)]` on by default
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>
> applied series with Lukas' R-b, thanks!
Thanks! I don't see the first commit in the series ()`clippy: remove
needless borrow`) in the repository, is it possible that it slipped by?
--
Maximiliano
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-08-09 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 7:43 [pbs-devel] " Maximiliano Sandoval
2024-08-07 7:43 ` [pbs-devel] [PATCH proxmox 02/10] apt: clippy: don't clone types implementing Copy Maximiliano Sandoval
2024-08-07 7:43 ` [pbs-devel] [PATCH proxmox 03/10] docs: clippy: add indentation to doc list items Maximiliano Sandoval
2024-08-07 7:43 ` [pbs-devel] [PATCH proxmox 04/10] property_string: clippy: define bound once Maximiliano Sandoval
2024-08-07 7:43 ` [pbs-devel] [PATCH proxmox 05/10] client: docs: remove redundant link Maximiliano Sandoval
2024-08-07 7:43 ` [pbs-devel] [PATCH proxmox 06/10] ldap: docs: turn uri into link Maximiliano Sandoval
2024-08-07 7:43 ` [pbs-devel] [PATCH proxmox 07/10] login: docs: fix typo and add escape html tags Maximiliano Sandoval
2024-08-07 7:43 ` [pbs-devel] [PATCH proxmox 08/10] serde: docs: " Maximiliano Sandoval
2024-08-07 7:43 ` [pbs-devel] [PATCH proxmox 09/10] server: docs: fix unresolved link to systemd_notify Maximiliano Sandoval
2024-08-07 7:43 ` [pbs-devel] [PATCH proxmox 10/10] auth-api: docs: remove wrong return info Maximiliano Sandoval
2024-08-07 9:32 ` [pbs-devel] [PATCH proxmox 01/10] clippy: remove needless borrow Lukas Wagner
2024-08-07 18:59 ` [pbs-devel] applied-series: " Thomas Lamprecht
2024-08-09 11:11 ` Maximiliano Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8o8qx6ar37.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox