Re: [PATCH proxmox-mail-forward 3/5] forward using PBS' notification worker

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Thu, Apr 09, 2026 at 03:27:19PM +0200, Lukas Wagner wrote:
> Instead of sending the notification ourselves, use the fact that we
> already have a 'notification queue' handled by a dedicated worker task
> in PBS. Up until now, it was only used for sending notifications from
> the unprivileged proxy process, but nothing speaks against doing the
> same for forwarded emails.
> 
> At some point, we should also introduce this worker in PVE -- then we
> can use the same approach here for PVE as well. When this is done, we
> gain the following advantages:
> 
>   - we don't need to bump proxmox-mail-forward if there are changes in
>     proxmox-notify (as soon as PVE uses the same approach as well)
> 
>   - we can drop the notification context implementations from
>     proxmox_notify and move them to the actual product code, where they
>     belong
yay!
> 
>   - proxmox-mail-forward becomes extremely simple and light-weight --
>     the only thing from proxmox-notify is the serializable Notification
>     struct, which could be put into a separate crate or made available
>     via a feature flag.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
[...]

Tested these changes on both PVE and PBS, did not run into any issues.
As mentioned in the cover letter, there is breakage when using an
upgraded proxmox-mail-forward on a non-upgraded PBS instance (i.e. 
that does not yet have the 
/var/lib/proxmox-backup/notifications/queue directory).

Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Reviewed-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>