public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox 01/12] ldap: add method for retrieving root DSE attributes
Date: Fri, 11 Aug 2023 12:29:51 +0200	[thread overview]
Message-ID: <pootmbug2wpz32hlkafkq4ypc5t7n736ixyrpbkr4uz5vxivk6@et76go3powrf> (raw)
In-Reply-To: <20230808122239.1025524-2-c.heiss@proxmox.com>

On Tue, Aug 08, 2023 at 02:22:03PM +0200, Christoph Heiss wrote:
> The root DSE holds common attributes about the LDAP server itself.
> Needed to e.g. support Active Directory-based LDAP servers to retrieve
> the base DN from the server itself, based on an valid bind.
> 
> See also RFC 4512, Section 5.1 [0] for more information about this
> special object.
> 
> [0] https://www.rfc-editor.org/rfc/rfc4512#section-5.1
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  proxmox-ldap/src/lib.rs              | 22 ++++++++++++++++++++++
>  proxmox-ldap/tests/assets/glauth.cfg |  1 +
>  proxmox-ldap/tests/glauth.rs         | 16 ++++++++++++++++
>  3 files changed, 39 insertions(+)
> 
> diff --git a/proxmox-ldap/src/lib.rs b/proxmox-ldap/src/lib.rs
> index b3b5d65..534c0c8 100644
> --- a/proxmox-ldap/src/lib.rs
> +++ b/proxmox-ldap/src/lib.rs
> @@ -198,6 +198,28 @@ impl Connection {
>          Ok(())
>      }
> 
> +    /// Retrieves an attribute from the root DSE according to RFC 4512, Section 5.1
> +    /// https://www.rfc-editor.org/rfc/rfc4512#section-5.1
> +    pub async fn retrieve_root_dse_attr(&self, attr: &str) -> Result<Vec<String>, Error> {
> +        let mut ldap = self.create_connection().await?;
> +
> +        let (entries, _res) = ldap
> +            .search("", Scope::Base, "(objectClass=*)", vec![attr])

The last parameter of `search` is an `impl AsRef<[impl AsRef<str>]>`, so
you can just pass `&[attr]` here.
The 2 other existing search calls in the crate should also be adapted,
there's no point in the extra allocation.

> +            .await?
> +            .success()?;
> +
> +        if entries.len() > 1 {
> +            bail!("found multiple root DSEs with attribute '{attr}'");
> +        }
> +
> +        entries
> +            .into_iter()
> +            .next()
> +            .map(SearchEntry::construct)
> +            .and_then(|e| e.attrs.get(attr).cloned())
> +            .ok_or_else(|| format_err!("failed to retrieve root DSE attribute '{attr}'"))
> +    }
> +
>      /// Retrive port from LDAP configuration, otherwise use the correct default
>      fn port_from_config(&self) -> u16 {
>          self.config.port.unwrap_or_else(|| {




  reply	other threads:[~2023-08-11 10:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 12:22 [pbs-devel] [PATCH proxmox/proxmox-backup/pwt 0/12] add Active Directory realm support Christoph Heiss
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox 01/12] ldap: add method for retrieving root DSE attributes Christoph Heiss
2023-08-11 10:29   ` Wolfgang Bumiller [this message]
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox 02/12] auth-api: implement `Display` for `Realm{, Ref}` Christoph Heiss
2023-08-11 10:32   ` Wolfgang Bumiller
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox-backup 03/12] api-types: implement `LdapMode` -> `ConnectionMode` conversion Christoph Heiss
2023-08-11 10:36   ` Wolfgang Bumiller
2023-08-14  9:40     ` Christoph Heiss
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox-backup 04/12] auth: factor out CA store and cert lookup into own function Christoph Heiss
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox-backup 05/12] api-types: implement `Display`, `FromStr` for `RealmType` Christoph Heiss
2023-08-11 10:58   ` Wolfgang Bumiller
2023-08-14  9:40     ` Christoph Heiss
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox-backup 06/12] realm sync: generic-ify `LdapSyncSettings` and `GeneralSyncSettings` Christoph Heiss
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox-backup 07/12] api: access: add routes for managing AD realms Christoph Heiss
2023-08-09 10:12   ` Lukas Wagner
2023-08-09 10:54     ` Christoph Heiss
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox-backup 08/12] config: domains: add new "ad" section type for " Christoph Heiss
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox-backup 09/12] realm sync: add sync job " Christoph Heiss
2023-08-09 10:12   ` Lukas Wagner
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox-backup 10/12] manager: add subcommand for managing " Christoph Heiss
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox-backup 11/12] docs: user-management: add section about AD realm support Christoph Heiss
2023-08-09 10:12   ` Lukas Wagner
2023-08-08 12:22 ` [pbs-devel] [PATCH proxmox-widget-toolkit 12/12] window: add Active Directory auth panel Christoph Heiss
2023-08-09 10:13   ` Lukas Wagner
2023-08-09 10:57     ` Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pootmbug2wpz32hlkafkq4ypc5t7n736ixyrpbkr4uz5vxivk6@et76go3powrf \
    --to=w.bumiller@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal