public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox] s3-client: drop to restrictive minimum length check in region schema
Date: Mon, 25 Aug 2025 11:36:14 +0200	[thread overview]
Message-ID: <lljur67jim6w5izc45bu47oaebh7ywh66lrfkhrf4efts43asz@4hx7bmrswdp7> (raw)
In-Reply-To: <20250822151239.634129-1-c.ebner@proxmox.com>

applied, thanks

On Fri, Aug 22, 2025 at 05:12:39PM +0200, Christian Ebner wrote:
> As reported in the community forum, the current minimum length of 3
> characters for regions to be set in the s3 endpoint configuration is
> to restrictive, as at least OVH also allows 2 character regions [0].
> 
> The region regex pattern already limits the minimum input anyways, so
> simply drop the currently set minimum length check.
> 
> [0] https://help.ovhcloud.com/csm/en-public-cloud-storage-s3-location?id=kb_article_view&sysparm_article=KB0047384
> 
> Fixes: https://forum.proxmox.com/threads/170146/
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  proxmox-s3-client/src/api_types.rs | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/proxmox-s3-client/src/api_types.rs b/proxmox-s3-client/src/api_types.rs
> index c68d85ef..115b1d2d 100644
> --- a/proxmox-s3-client/src/api_types.rs
> +++ b/proxmox-s3-client/src/api_types.rs
> @@ -47,7 +47,6 @@ pub const S3_ENDPOINT_SCHEMA: Schema = StringSchema::new("Endpoint to access S3
>  /// Region to access S3 object store.
>  pub const S3_REGION_SCHEMA: Schema = StringSchema::new("Region to access S3 object store.")
>      .format(&S3_REGION_FORMAT)
> -    .min_length(3)
>      .max_length(32)
>      .schema();
>  
> -- 
> 2.47.2


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      reply	other threads:[~2025-08-25  9:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22 15:12 [pbs-devel] " Christian Ebner
2025-08-25  9:36 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lljur67jim6w5izc45bu47oaebh7ywh66lrfkhrf4efts43asz@4hx7bmrswdp7 \
    --to=w.bumiller@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal