* [pbs-devel] [PATCH proxmox] schema: drop leftover useless i64 check
@ 2025-10-14 10:24 Fabian Grünbichler
2025-11-05 13:54 ` [pbs-devel] applied: " Wolfgang Bumiller
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2025-10-14 10:24 UTC (permalink / raw)
To: pbs-devel
since 7ac306e268e2840d258af41ce8cec890fc372351 IntegerSchema is no longer
isize, but i64, so this check is pointless.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
clippy complained about the useless conversion here, sending on-list in case I
missed something..
proxmox-schema/src/de/mod.rs | 3 ---
1 file changed, 3 deletions(-)
diff --git a/proxmox-schema/src/de/mod.rs b/proxmox-schema/src/de/mod.rs
index 1f14503e..ea2115c5 100644
--- a/proxmox-schema/src/de/mod.rs
+++ b/proxmox-schema/src/de/mod.rs
@@ -180,9 +180,6 @@ impl<'de> de::Deserializer<'de> for SchemaDeserializer<'de, '_> {
schema.check_constraints(value).map_err(Error::invalid)?;
- let value: i64 = i64::try_from(value)
- .map_err(|_| Error::invalid("isize did not fit into i64"))?;
-
if let Ok(value) = u64::try_from(value) {
visitor.visit_u64(value)
} else {
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox] schema: drop leftover useless i64 check
2025-10-14 10:24 [pbs-devel] [PATCH proxmox] schema: drop leftover useless i64 check Fabian Grünbichler
@ 2025-11-05 13:54 ` Wolfgang Bumiller
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Bumiller @ 2025-11-05 13:54 UTC (permalink / raw)
To: Fabian Grünbichler; +Cc: pbs-devel
applied, thanks
On Tue, Oct 14, 2025 at 12:24:12PM +0200, Fabian Grünbichler wrote:
> since 7ac306e268e2840d258af41ce8cec890fc372351 IntegerSchema is no longer
> isize, but i64, so this check is pointless.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> clippy complained about the useless conversion here, sending on-list in case I
> missed something..
>
> proxmox-schema/src/de/mod.rs | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/proxmox-schema/src/de/mod.rs b/proxmox-schema/src/de/mod.rs
> index 1f14503e..ea2115c5 100644
> --- a/proxmox-schema/src/de/mod.rs
> +++ b/proxmox-schema/src/de/mod.rs
> @@ -180,9 +180,6 @@ impl<'de> de::Deserializer<'de> for SchemaDeserializer<'de, '_> {
>
> schema.check_constraints(value).map_err(Error::invalid)?;
>
> - let value: i64 = i64::try_from(value)
> - .map_err(|_| Error::invalid("isize did not fit into i64"))?;
> -
> if let Ok(value) = u64::try_from(value) {
> visitor.visit_u64(value)
> } else {
> --
> 2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-05 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-14 10:24 [pbs-devel] [PATCH proxmox] schema: drop leftover useless i64 check Fabian Grünbichler
2025-11-05 13:54 ` [pbs-devel] applied: " Wolfgang Bumiller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox