From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v2 0/2] GC: log progress output for phase 2 S3 datastores
Date: Fri, 23 Jan 2026 14:39:25 +0100 [thread overview]
Message-ID: <kyxm3fkwmub66dlndk3365fv5lw4gbt3wqs5ekkpth4tbmnqpq@r4g2j527mqhx> (raw)
In-Reply-To: <20260121104537.495434-1-c.ebner@proxmox.com>
On Wed, Jan 21, 2026 at 11:45:35AM +0100, Christian Ebner wrote:
> This patch series adds accounting for basic request statistics to
> the S3 client, and uses it to provide request count and average
> request time for phase 2 of garbage collection on S3 stores.
>
> Logging for phase 2 is implemented using a rate limited logger
> implementation, to control the number of output lines and avoid
> log spamming, given that the total number of objects cannot be
> determined a-priori.
>
> Output the number of processed chunks as well as to be removed
> object count and size, including the number of objects still pending
> a delete API call as stored in the delete list.
>
> Changes since v1 (thanks @Fabian for feedback):
> - Switch from dedicated thread output for logging to the rate limited
> logging implementation.
> - Extend logging output to include delete object accounting and
> request statistics.
>
Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
I tested these changes on a local MinIO S3 datastore, the rate-limited
logging output appears at the expected intervals, and the request statistics
are accurately displayed.
Just one question maybe: why is sequential consistency needed for the request
counters? Wouldn't relaxed ordering be sufficient for statistics?
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2026-01-23 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 10:45 Christian Ebner
2026-01-21 10:45 ` [pbs-devel] [PATCH proxmox v2 1/1] s3-client: add request statistics gathering capabilities Christian Ebner
2026-01-21 10:45 ` [pbs-devel] [PATCH proxmox-backup v2 1/1] GC: log progress output for phase 2 on datastores backed by s3 Christian Ebner
2026-01-23 13:39 ` Arthur Bied-Charreton [this message]
2026-01-23 13:54 ` [pbs-devel] [PATCH proxmox{, -backup} v2 0/2] GC: log progress output for phase 2 S3 datastores Christian Ebner
2026-01-23 14:02 ` Arthur Bied-Charreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kyxm3fkwmub66dlndk3365fv5lw4gbt3wqs5ekkpth4tbmnqpq@r4g2j527mqhx \
--to=a.bied-charreton@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox