From: Christoph Heiss <c.heiss@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup/pwt 0/14] fix #5379: introduce default auth realm option
Date: Thu, 8 Aug 2024 16:25:08 +0200 [thread overview]
Message-ID: <kl2wqxl3qp744fgcgnglfpt33glinbfdxzeryzzwpzhct5rs3a@xfbq6rpqcfnl> (raw)
In-Reply-To: <xl6f7r5kgkafhhnvzs3e3qnqf5gmqrjrb6yyrl775y5tpipecx@eybahq3adgyc>
On Wed, Aug 07, 2024 at 05:27:42PM GMT, Christoph Heiss wrote:
> Thanks for the review & testing!
>
> On Wed, Aug 07, 2024 at 11:23:55AM GMT, Lukas Wagner wrote:
> > [..]
> > I found that once you select PAM again and log in as root, the PAM realm will
> > be selected on next login again (even though 'save user' is not selected).
> > This seems to happen because the ext-pbs-pveloginrealm:"o%3Avalue%3Ds%253Apam"
> > key is set in local storage. If that one is cleared, it works again.
> > So it seems like we are interfering with the statefulness of the login widget.
> >
> > Could you check if you can reproduce that?
>
> Also, thanks for the investigation! I'll check if I can reproduce it,
> the fix for it seems to be doable in a sensible way by clearing the key.
>
Following up on this: PVE has the exact same behaviour. The login dialog
component (`Proxmox.form.RealmComboBox`, living in
proxmox-widget-toolkit) is in fact reused between both frontends.
PVE uses the key `ext-pveloginrealm` in local storage, PBS
`ext-pbs-pveloginrealm`.
So IMHO either we should keep the behaviour as-is or change it for both,
the latter preferably as a separate changeset.
I would even argue to keep the behaviour, since it makes sense to me -
if a user once logs in using a specific realm, he will probably want to
*always* log in with that realm.
What do you think?
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-08-08 14:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 13:44 Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH widget-toolkit 1/6] window: AuthEditBase: include more information in thrown errors Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH widget-toolkit 2/6] panel: AuthView: make `useTypeInUrl` property per-realm Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH widget-toolkit 3/6] window: add panel for editing simple, built-in realms Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH widget-toolkit 4/6] schema: make PAM realm editable using new AuthSimple panel Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH widget-toolkit 5/6] fix #5379: panel: AuthView: add column displaying whether the realm is default Christoph Heiss
2024-08-07 9:24 ` Lukas Wagner
2024-07-16 13:45 ` [pbs-devel] [PATCH widget-toolkit 6/6] fix #5379: window: AuthEdit{LDAP, OpenId}: add 'Default realm' checkbox Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH proxmox-backup 07/14] fix #5379: api-types: add `default` field to all realm types Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH proxmox-backup 08/14] fix #5379: api2: access: set default realm accordingly on individual update Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH proxmox-backup 09/14] api-types: introduce proper types for PAM and PBS realms Christoph Heiss
2024-08-07 9:24 ` Lukas Wagner
2024-07-16 13:45 ` [pbs-devel] [PATCH proxmox-backup 10/14] config: use new dedicated PAM and PBS realm types Christoph Heiss
2024-08-07 9:24 ` Lukas Wagner
2024-08-07 15:24 ` Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH proxmox-backup 11/14] api2: access: add update support for built-in PAM realm Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH proxmox-backup 12/14] api2: access: add update support for built-in PBS realm Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH proxmox-backup 13/14] www: AccessControl: make `useTypeInUrl` property per-realm Christoph Heiss
2024-07-16 13:45 ` [pbs-devel] [PATCH proxmox-backup 14/14] www: utils: make built-in pbs realm editable using new AuthSimplePanel Christoph Heiss
2024-08-07 9:23 ` [pbs-devel] [PATCH proxmox-backup/pwt 0/14] fix #5379: introduce default auth realm option Lukas Wagner
2024-08-07 15:27 ` Christoph Heiss
2024-08-08 14:25 ` Christoph Heiss [this message]
2024-08-09 11:12 ` Lukas Wagner
2024-08-12 13:57 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kl2wqxl3qp744fgcgnglfpt33glinbfdxzeryzzwpzhct5rs3a@xfbq6rpqcfnl \
--to=c.heiss@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox