public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Gabriel Goller <g.goller@proxmox.com>,
	 Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: Outsource the logger initialization to the router
Date: Fri, 29 Sep 2023 11:49:22 +0200	[thread overview]
Message-ID: <jafju2ed6q5kuktplrslu6jde3aznhovy6yc7cwdifzdsl6h3v@25okbn7av7yr> (raw)
In-Reply-To: <cf4369be-147c-46a9-a332-6b3cbb18f500@proxmox.com>

On Fri, Sep 29, 2023 at 11:35:06AM +0200, Dominik Csapak wrote:
> high level comment:
> 
> is proxmox-router really the right place for this?
> 
> IMHO where we want to log to should be decided by each binary/daemon/utility etc. and
> not in the crate responsible for routing api requests?
> 
> It would at least be better if it would be it's own crate (e.g. proxmox-log ?)
> 
> I just say this because if we want to rework the logging from workers (which
> live in proxmox-rest-server) this could complicate things
> (though i did not spend too much time thinking what the possible issues could be)
> 
> whats your opinion on that @wolfgang, @thomas?

On the one hand `proxmox-router` is used for both the API daemons and by
our schema-based CLI parser, and we already have `cli::init_cli_logger`
in there.
On the other hand, there's no guarantee that all daemons will use this
crate, if they don't need any schema/CLI parsing, but then again this
can still be initialized specially there...

Basically, I don't specifically object to having a common helper for
a "this is how our daemons usually do logging" type of deal, but it may
still make more sense in proxmox-rest-server.

Regardless of where we put it, for our log refactoring, we'd need this
to return a logger instance, rather than actually setting the logger,
because our API daemons will need a *custom* logger to deal with the
workers, which in turn needs access to the logger created *here*.

The custom logger would then definitely go into `proxmox-rest-server`,
so the syslog portion may as well live there, depending on which we'd
consider more "consistent" with the CLI portion being in
`proxmox-router` - the CLI tools definitely won't want to pull in
`proxmox-rest-server`, so moving the cli logger setup there doesn't make
sense.




  reply	other threads:[~2023-09-29  9:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21 11:19 Gabriel Goller
2023-08-21 11:19 ` [pbs-devel] [PATCH proxmox] router: Added `init_syslog_logger()` function Gabriel Goller
2023-09-29  8:47 ` [pbs-devel] [PATCH proxmox-backup] api: Outsource the logger initialization to the router Gabriel Goller
2023-09-29  9:35 ` Dominik Csapak
2023-09-29  9:49   ` Wolfgang Bumiller [this message]
2023-09-29 10:23     ` Dominik Csapak
2023-09-29 11:09     ` Gabriel Goller
2023-09-29 11:46       ` Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jafju2ed6q5kuktplrslu6jde3aznhovy6yc7cwdifzdsl6h3v@25okbn7av7yr \
    --to=w.bumiller@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal